8000 Add unit test for PublishMetadata, Version command by BurningCN · Pull Request #7906 · apache/dubbo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add unit test for PublishMetadata, Version command #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 1, 2021
Merged

Add unit test for PublishMetadata, Version command #7906

merged 19 commits into from
Jun 1, 2021

Conversation

BurningCN
Copy link
Member

What is the purpose of the change

Add unit test for Ready, PublishMetadata, Version command

@codecov-commenter
Copy link
codecov-commenter commented May 28, 2021 •
edited
Loading

Codecov Report

Merging #7906 (95e85dc) into master (e845e16) will increase coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7906      +/-   ##
============================================
+ Coverage     59.28%   60.24%   +0.96%     
- Complexity      529      545      +16     
============================================
  Files          1077     1089      +12     
  Lines         43565    43845     +280     
  Branches       6368     6404      +36     
============================================
+ Hits          25826    26414     +588     
+ Misses        14879    14479     -400     
- Partials       2860     2952      +92
Impacted Files Coverage Δ
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...org/apache/dubbo/remoting/zookeeper/EventType.java 0.00% <0.00%> (-61.91%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-60.00%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 0.00% <0.00%> (-56.25%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 31.42% <0.00%> (-48.58%) ⬇️
.../dubbo/remoting/transport/MultiMessageHandler.java 80.00% <0.00%> (-20.00%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 52.45% <0.00%> (-18.04%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) ⬇️
...ing/zookeeper/support/AbstractZookeeperClient.java 65.82% <0.00%> (-8.87%) ⬇️
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e845e16...95e85dc. Read the comment docs.

@BurningCN BurningCN changed the title Add unit test for Ready, PublishMetadata, Version command Add unit test for PublishMetadata, Version command May 31, 2021
@BurningCN BurningCN requested a review from AlbumenJ May 31, 2021 10:06
@BurningCN
Copy link
Member Author

ReadyTest reports NPE during check, I temporarily remove this test class

@AlbumenJ AlbumenJ merged commit 8d66c83 into apache:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbumenJ AlbumenJ Awaiting requested review from AlbumenJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BurningCN @codecov-commenter @AlbumenJ
0