8000 Refactor transaction message type tests by lorisleiva · Pull Request #428 · anza-xyz/kit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor transaction message type tests #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Refactor transaction message type tests #428

merged 1 commit into from
May 14, 2025

Conversation

lorisleiva
Copy link
Member
@lorisleiva lorisleiva commented May 1, 2025 •
edited
Loading

This PR mainly splits the type tests of the transaction-message-typetests.ts files into more granular files — some already existing.

Additionally it extracts a durable-nonce-instruction.ts file from durable-nonce.ts.

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5311cc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here t 8000 o learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link
vercel bot commented May 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kit-docs ❌ Failed (Inspect) May 2, 2025 5:02pm

This was referenced May 1, 2025
Merged
Merged
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented May 1, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced May 1, 2025
Merged
Merged
Merged
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from 71a0867 to ecdf9f2 Compare May 1, 2025 17:38
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from 3582177 to b1d3ba0 Compare May 1, 2025 17:38
@bundlemon BundleMon
Copy link
bundlemon bot commented May 1, 2025 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ transaction-messages/dist/index.browser.mjs
 7.29KB (+13B +0.17%) -
✅ transaction-messages/dist/index.native.mjs
 7.29KB (+13B +0.17%) -
✅ transaction-messages/dist/index.node.mjs
 7.29KB (+13B +0.17%) -
Unchanged files (124)
Status Path Size Limits
✅ @solana/kit production bundle
kit/dist/index.production.min.js
 34.4KB -
✅ rpc-graphql/dist/index.browser.mjs
 18.78KB -
✅ rpc-graphql/dist/index.native.mjs
 18.78KB -
✅ rpc-graphql/dist/index.node.mjs
 18.78KB -
✅ errors/dist/index.node.mjs
 14.54KB -
✅ errors/dist/index.browser.mjs
 14.52KB -
✅ errors/dist/index.native.mjs
 14.52KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.77KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.77KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.57KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.56KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.54KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.38KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ codecs-core/dist/index.browser.mjs
 3.3KB -
✅ codecs-core/dist/index.native.mjs
 3.3KB -
✅ codecs-core/dist/index.node.mjs
 3.3KB -
✅ rpc-transformers/dist/index.browser.mjs
 2.93KB -
✅ rpc-transformers/dist/index.native.mjs
 2.93KB -
✅ rpc-transformers/dist/index.node.mjs
 2.93KB -
✅ addresses/dist/index.browser.mjs
 2.86KB -
✅ addresses/dist/index.native.mjs
 2.86KB -
✅ addresses/dist/index.node.mjs
 2.86KB -
✅ kit/dist/index.browser.mjs
 2.71KB -
✅ kit/dist/index.native.mjs
 2.71KB -
✅ kit/dist/index.node.mjs
 2.71KB -
✅ signers/dist/index.browser.mjs
 2.63KB -
✅ signers/dist/index.native.mjs
 2.63KB -
✅ signers/dist/index.node.mjs
 2.63KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.48KB -
✅ codecs-strings/dist/index.native.mjs
 2.45KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.4KB -
✅ sysvars/dist/index.browser.mjs
 2.35KB -
✅ sysvars/dist/index.native.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.34KB -
✅ sysvars/dist/index.node.mjs
 2.34KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.34KB -
✅ transactions/dist/index.browser.mjs
 2.22KB -
✅ transactions/dist/index.native.mjs
 2.22KB -
✅ transactions/dist/index.node.mjs
 2.22KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.13KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.08KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.08KB -
✅ keys/dist/index.browser.mjs
 2.02KB -
✅ keys/dist/index.native.mjs
 2.02KB -
✅ keys/dist/index.node.mjs
 2.02KB -
✅ codecs-numbers/dist/index.native.mjs
 2.01KB -
✅ codecs-numbers/dist/index.browser.mjs
 2.01KB -
✅ codecs-numbers/dist/index.node.mjs
 2.01KB -
✅ react/dist/index.native.mjs
 1.99KB -
✅ react/dist/index.browser.mjs
 1.99KB -
✅ react/dist/index.node.mjs
 1.99KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.91KB -
✅ rpc/dist/index.native.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.73KB -
✅ rpc-types/dist/index.browser.mjs
 1.6KB -
✅ rpc-types/dist/index.native.mjs
 1.6KB -
✅ rpc-types/dist/index.node.mjs
 1.6KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.13KB -
✅ accounts/dist/index.native.mjs
 1.12KB -
✅ accounts/dist/index.node.mjs
 1.12KB -
✅ compat/dist/index.browser.mjs
 971B -
✅ compat/dist/index.native.mjs
 970B -
✅ compat/dist/index.node.mjs
 968B -
✅ rpc-spec-types/dist/index.browser.mjs
 964B -
✅ rpc-api/dist/index.browser.mjs
 963B -
✅ rpc-api/dist/index.native.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 962B -
✅ rpc-api/dist/index.node.mjs
 961B -
✅ rpc-spec-types/dist/index.node.mjs
 961B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 829B -
✅ rpc-spec/dist/index.native.mjs
 829B -
✅ rpc-spec/dist/index.node.mjs
 828B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 783B -
✅ instructions/dist/index.browser.mjs
 769B -
✅ instructions/dist/index.native.mjs
 768B -
✅ instructions/dist/index.node.mjs
 767B -
✅ fast-stable-stringify/dist/index.browser.mjs
 726B -
✅ fast-stable-stringify/dist/index.native.mjs
 725B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.node.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ programs/dist/index.browser.mjs
 329B -
✅ programs/dist/index.native.mjs
 327B -
✅ programs/dist/index.node.mjs
 325B -
✅ event-target-impl/dist/index.node.mjs
 233B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ crypto-impl/dist/index.node.mjs
 114B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

Total files change +40B +0.01%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@lorisleiva lorisleiva marked this pull request as ready for review May 1, 2025 17:50
mcintyre94
mcintyre94 approved these changes May 2, 2025
View reviewed changes
Copy link
Member
@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from ecdf9f2 to 8ee4899 Compare May 2, 2025 16:11
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from b1d3ba0 to afbba91 Compare May 2, 2025 16:11
@lorisleiva lorisleiva mentioned this pull request May 2, 2025
Merged
steveluscher
steveluscher approved these changes May 5, 2025
View reviewed changes
Copy link
Collaborator
@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added via Giphy

@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from afbba91 to d99d7e0 Compare May 5, 2025 13:45
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch 2 times, most recently from b379489 to 5b952c3 Compare May 5, 2025 14:30
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from d99d7e0 to 43370c2 Compare May 5, 2025 14:30
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from 5b952c3 to b0c1510 Compare May 5, 2025 14:39
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch 2 times, most recently from 8ac8b08 to 91b6850 Compare May 6, 2025 08:26
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from b0c1510 to 6f0f0ff Compare May 6, 2025 08:26
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from 165d90b to 8cda7f9 Compare May 8, 2025 15:02
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch 2 times, most recently from 7ab090e to 1e80ed8 Compare May 8, 2025 15:15
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from 8cda7f9 to 5e556a5 Compare May 8, 2025 15:15
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from 1e80ed8 to 87c0664 Compare May 8, 2025 15:43
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from 5e556a5 to ca04550 Compare May 8, 2025 15:43
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from 87c0664 to f9c5cec Compare May 8, 2025 15:53
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from ca04550 to f8a8ef2 Compare May 8, 2025 15:53
@lorisleiva lorisleiva mentioned this pull request May 8, 2025
Open
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from f8a8ef2 to 929513a Compare May 8, 2025 21:40
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch 2 times, most recently from 99a826b to 515f265 Compare May 8, 2025 21:49
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch 2 times, most recently from 2487c76 to aff3a00 Compare May 12, 2025 10:04
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from 515f265 to db9bc59 Compare May 12, 2025 10:04
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from aff3a00 to eca8c9f Compare May 12, 2025 10:17
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from db9bc59 to 4483fed Compare May 12, 2025 10:17
@lorisleiva lorisleiva mentioned this pull request May 12, 2025
Merged
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from eca8c9f to 717b6ba Compare May 14, 2025 08:31
@lorisleiva lorisleiva force-pushed the 05-01-rename_durablenoncelifetime_helpers branch from 4483fed to 046309d Compare May 14, 2025 08:31
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from 717b6ba to 2cb2bd8 Compare May 14, 2025 09:01
@lorisleiva Graphite App
Copy link
Member Author
lorisleiva commented May 14, 2025 •
edited
Loading

Merge activity

  • May 14, 5:56 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 14, 6:06 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 14, 6:09 AM EDT: @lorisleiva merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from 05-01-rename_durablenoncelifetime_helpers to graphite-base/428 May 14, 2025 10:02
@lorisleiva lorisleiva changed the base branch from graphite-base/428 to main May 14, 2025 10:05
@lorisleiva lorisleiva force-pushed the 05-01-refactor_transaction_message_lifetime_type_tests branch from 2cb2bd8 to 5311cc3 Compare May 14, 2025 10:06
@lorisleiva lorisleiva merged commit a4bc1ad into main May 14, 2025
14 checks passed
@lorisleiva lorisleiva deleted the 05-01-refactor_transaction_message_lifetime_type_tests branch May 14, 2025 10:09
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveluscher steveluscher steveluscher approved these changes

@mcintyre94 mcintyre94 mcintyre94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorisleiva @steveluscher @mcintyre94
0