Use TransactionMessageWithinSizeLimit in helper functions
#468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a72451 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced May 6, 2025
BundleMonFiles updated (10)
Unchanged files (117)
Total files change +788B +0.22% Final result: ✅ View report in BundleMon website ➡️ |
dd2f2ca to
55b2177
Compare
87e27cf to
af5d54a
Compare
Merged
55b2177 to
e92d632
Compare
af5d54a to
51d3791
Compare
e92d632 to
d0b31b2
Compare
|
Documentation Preview: https://kit-docs-h48nru5ks-anza-tech.vercel.app |
d0b31b2 to
0128277
Compare
13ffe0b to
e09c9e5
Compare
0128277 to
c1b833d
Compare
e09c9e5 to
924e539
Compare
d2c1252 to
a9d2409
Compare
steveluscher
approved these changes
May 8, 2025
| * A type guard that checks if a transaction message is within the size limit | ||
| * when compiled into a transaction. | ||
| */ | ||
| export type TransactionMessageWithinSizeLimit = { readonly __within_size_limit: unique symbol }; |
There was a problem hiding this comment.
Consider how you're going to implement this. I'll throw out some thoughts but ultimately leave it up to you.
NominalType<'withinSizeLimit', true>; // Either present or not
NominalType<'relationshipToSizeLimit', 'under' | 'meets' | 'over'>; // Useful? I don't know.
NominalType<'size', 'within_1232'>; // Imagine a world where the size limit gets increased. Do we need to be able to distinguish between limits at different versions of the cluster?There was a problem hiding this comment.
I'm thinking:
NominalType<'transactionSize', 'withinLimit'>As it follows a similar convention to the existing:
NominalType<'transactionSignedness', 'fullySigned'>I don't think there is any point in using values such as within_1232 since we are planning on fixing cluster differences at build time.
c787e76 to
33bcc16
Compare
a9d2409 to
1ff66ef
Compare
33bcc16 to
9065d3a
Compare
1ff66ef to
d55aa07
Compare
9065d3a to
f995600
Compare
6ec858e to
f780cb8
Compare
f995600 to
8d02b50
Compare
8d02b50 to
c471402
Compare
f780cb8 to
2311a56
Compare
2311a56 to
d205506
Compare
c471402 to
3dc8904
Compare
d205506 to
61c1f71
Compare
3dc8904 to
4165595
Compare
Merge activity
|
61c1f71 to
6a72451
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds, removes or forwards the
TransactionMessageWithinSizeLimitandTransactionWithinSizeLimittypes in all helpers that may affect the size of a transaction.Namely it does the following:
TransactionMessageWithinSizeLimittype to@solana/transaction-messagesso it can be used within transaction message helpers (not we cannot move the other helper functions since they rely on compiling the transaction to get its size).ExcludeTransactionMessageWithinSizeLimittype helper to remove the size limit type safety from a message.createTransactionMessagereturn type since it always returns empty messages.SetTransactionWithinSizeLimitFromTransactionMessagetype helper that forwards the size limit type safety from a message to a transaction, if any.SetTransactionLifetimeFromCompilableTransactionMessagetype helper that forwards the lifetime constraint from a message to a transaction, if any.TransactionFromCompilableTransactionMessagetype helper that creates aTransactiontype with all the appropriate flags based on the provided message. This helper is then used in the following helpers to significantly simplify their function signatures (they now only require one):compileTransactionsignTransactionMessageWithSignerspartiallySignTransactionMessageWithSigners