8000 Make city, state, street_address, and zip_code fields nullable in tax data schema by raulpopadineti · Pull Request #268 · antiwork/flexile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make city, state, street_address, and zip_code fields nullable in tax data schema #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged

Make city, state, street_address, and zip_code fields nullable in tax data schema #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfa9db8
Make city, state, street_address, and zip_code fields nullable in tax…
raulpopadineti May 6, 2025
cca90e9
f
raulpopadineti May 6, 2025
1b63958
f
raulpopadineti May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/next/app/documents/DocusealForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export const customCss = `
}

.scrollbox {
height: 100vh;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the signing fields were jumping off the screen during the signature flow because of the vh. Added a min-height for now to make tests happy and ensure the signing box scrolls with the document pages as before.

min-height: 500px;
}

div:has(> .submitted-form-resubmit-button) {
Expand Down
17 changes: 12 additions & 5 deletions apps/next/app/settings/tax/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,19 @@ const dataSchema = z.object({
business_type: z.number().nullable(),
tax_classification: z.number().nullable(),
citizenship_country_code: z.string(),
city: z.string(),
city: z.string().nullable(),
country_code: z.string(),
display_name: z.string(),
business_entity: z.boolean(),
is_foreign: z.boolean(),
is_tax_information_confirmed: z.boolean(),
legal_name: z.string(),
signature: z.string(),
state: z.string(),
street_address: z.string(),
state: z.string().nullable(),
street_address: z.string().nullable(),
tax_id: z.string().nullable(),
tax_id_status: z.enum(["verified", "invalid"]).nullable(),
zip_code: z.string(),
zip_code: z.string().nullable(),
contractor_for_companies: z.array(z.string()),
});

Expand Down Expand Up @@ -104,7 +104,14 @@ export default function TaxPage() {

const form = useForm({
resolver: zodResolver(formSchema),
defaultValues: { ...data, tax_id: data.tax_id ?? "" },
defaultValues: {
...data,
5424 tax_id: data.tax_id ?? "",
city: data.city ?? "",
state: data.state ?? "",
zip_code: data.zip_code ?? "",
street_address: data.street_address ?? "",
},
});

const formValues = form.watch();
Expand Down
0