8000 Make city, state, street_address, and zip_code fields nullable in tax data schema by raulpopadineti · Pull Request #268 · antiwork/flexile · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make city, state, street_address, and zip_code fields nullable in tax data schema #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2025
Merged

Make city, state, street_address, and zip_code fields nullable in tax data schema #268

merged 3 commits into from
May 6, 2025

Conversation

raulpopadineti
Copy link
Contributor

Bug fix.

Before

image

After

image

Error

ZodError: [
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "city"
    ],
    "message": "Expected string, received null"
  },
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "state"
    ],
    "message": "Expected string, received null"
  },
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "street_address"
    ],
    "message": "Expected string, received null"
  },
  {
    "code": "invalid_type",
    "expected": "string",
    "received": "null",
    "path": [
      "zip_code"
    ],
    "message": "Expected string, received null"
  }
]
    at get error (index.mjs:587:1)
    at ZodObject.parse (index.mjs:663:1)
    at TaxPage.useSuspenseQuery (page.tsx:96:25)

raulpopadineti
raulpopadineti commented May 6, 2025
View reviewed changes
apps/next/app/documents/DocusealForm.tsx
@@ -92,7 +92,7 @@ export const customCss = `
}

.scrollbox {
height: 100vh;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed the signing fields were jumping off the screen during the signature flow because of the vh. Added a min-height for now to make tests happy and ensure the signing box scrolls with the document pages as before.

@raulpopadineti raulpopadineti merged commit d1ecc66 into main May 6, 2025
5 checks passed
@raulpopadineti raulpopadineti deleted the raul/fix-contractor-onboarding branch May 6, 2025 16:56
devin-ai-integration bot added a commit that referenced this pull request May 7, 2025
@devin-ai-integration @raulpopadineti
Add regression test for PR #268: nullable tax fields
6483794 
Co-Authored-By: raulp@hey.com <raulp@hey.com>
This was referenced May 7, 2025
Merged
Closed
Closed
MayaRainer added a commit that referenced this pull request May 11, 2025
@devin-ai-integration @raulpopadineti
@autofix-ci @MayaRainer
Add regression test for PR #268: nullable tax fields (#274)
b4ac62b 
# Add regression test for PR #268

This PR adds a Playwright regression test to verify the fix implemented
in PR #268.

Link to Devin run:
https://app.devin.ai/sessions/637de2c7b47c4942a8eed4ac81c09533

Requested by: raulp@hey.com

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: raulp@hey.com <raulp@hey.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Maya <19721695+code-elf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raulpopadineti
0