8000 Implement template inheritance by jorgepiloto · Pull Request #18 · ansys/ansys-templates · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement template inheritance #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 73 commits into from
Mar 21, 2022
Merged

Implement template inheritance #18

merged 73 commits into from
Mar 21, 2022

Conversation

jorgepiloto
Copy link
Member
@jorgepiloto jorgepiloto commented Mar 15, 2022 •
edited by akaszynski
Loading

Opening this in favor of #16 after experiencing really weird issues with GitHub.

Main goals of this PR:

  • Allow template inheritance.
  • Allow developers to easily add new templates.
  • Better modularization of the package.

Before merging:

  • Update pre-commit-config.yml to work with the new project layout.
  • Main CI should check for style, docs, smoke-tests and build of the ansys-templates tool.
  • One action per family template whose main goal is to check baked project integrity.
  • Add tool code coverage.
  • Update documentation by including new guidelines on how to add a new template.
  • Add CLI tests.
  • Update all README.rst files.
  • Clean commit history.

@jorgepiloto
Move whole template to common
4d44f24
@jorgepiloto
New templats/licenses/ directory
f3b4cda
@jorgepiloto
Move requirements/ to pypkg_advanced/
7e3d6aa
@jorgepiloto
Move .pre-commit-config.yaml to pypkg_advanced/
20ecde4
@jorgepiloto
Move tox config to pypkg_advanced/
894dd5a
@jorgepiloto
Move pyproject files to pypkg_advanced/
93422c0
@jorgepiloto
Move advanced setup.py files to pypkg_advanced/
14b41ee
@jorgepiloto
Move src/product/library layout to pypkg_advanced/
1836486
@jorgepiloto
Move advanced CI GitHub actions to pypkg_advanced/
2bc11d3
@jorgepiloto
Stash changes
a4edec9
@jorgepiloto
Inherit from template function
a250567
@jorgepiloto
Add testing and utils
97b855e
@jorgepiloto
Test pypkg template
54769c2
@jorgepiloto
Bake projects using tmp directory
1c7e85b
@jorgepiloto
Fix tmpdir not being removed
3e263c2
@jorgepiloto
Rename pypkg->pyansys pypkg_advanced->pyansys_advanced
b185a07
@jorgepiloto
Add advanced PyAnsys template
87ef686
@jorgepiloto
Add tox python marker
675fb35
@jorgepiloto
Use smoke tests in CI
6f80154
@jorgepiloto
Custom copytree function
6db5f4e
@jorgepiloto
Update pyproject.toml
8102a19
@jorgepiloto jorgepiloto marked this pull request as draft March 15, 2022 19:58
jorgepiloto and others added 5 commits March 18, 2022 20:09
@jorgepiloto @akaszynski
Update doc/source/user_guide/usage.rst
a6595fd 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@jorgepiloto @akaszynski
Update doc/source/user_guide/usage.rst
baa3516 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@jorgepiloto @akaszynski
Update doc/source/user_guide/usage.rst
96cb164 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@jorgepiloto @akaszynski
Update doc/source/user_guide/usage.rst
dadb36f 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@jorgepiloto @akaszynski
Update doc/source/user_guide/usage.rst
6210af4 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@akaszynski
Copy link
Contributor

Next time, please accept several suggestions in a "batch." See:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 18, 2022
View reviewed changes
@jorgepiloto @akaszynski
Apply suggestions from code review
09b6eef 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@jorgepiloto
Copy link
Member Author

Next time, please accept several suggestions in a "batch." See: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request

Will use it from now on, for sure ☝🏽

jorgepiloto
jorgepiloto commented Mar 21, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 21, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 21, 2022
View reviewed changes
akaszynski
akaszynski reviewed Mar 21, 2022
View reviewed changes
akaszynski
akaszynski approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor
@akaszynski akaszynski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes remain, but otherwise this is good to go.

Overall, this is excellent work. I especially like the testing sections, as this looks much easier to maintain via pytest rather than the makefile/script used in ansys/ansys-api-template.

@jorgepiloto @akaszynski
Fix links in various tempaltes/python/README.rst
f853867 
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@jorgepiloto
Copy link
Member Author

This is finally ready! Thanks @akaszynski for the review. Merging... 🚀

@jorgepiloto jorgepiloto merged commit 2326f7f into main Mar 21, 2022
@jorgepiloto jorgepiloto deleted the feat/templates branch March 21, 2022 09:14
This was referenced Mar 21, 2022
Closed
Closed
@anscfrisson anscfrisson mentioned this pull request Jun 20, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

@jgd10 jgd10 Awaiting requested review from jgd10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgepiloto @akaszynski
0