8000 Bug: `smoke-tests` should be named `build-wheelhouse` in the common `ci_cd.yml` template · Issue #491 · ansys/ansys-templates · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bug: smoke-tests should be named build-wheelhouse in the common ci_cd.yml template #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks done
anscfrisson opened this issue Jun 20, 2024 · 1 comment · May be fixed by #492
Open
2 tasks done

Bug: smoke-tests should be named build-wheelhouse in the common ci_cd.yml template #491

anscfrisson opened this issue Jun 20, 2024 · 1 comment · May be fixed by #492
Labels
bug Something isn't working

Comments

@anscfrisson
Copy link
anscfrisson commented Jun 20, 2024 •
edited
Loading

🔍 Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

🐞 Description of the bug

From src/ansys/templates/python/common/{{cookiecutter.__project_name_slug}}/.github/workflows/ci_cd.yml#L52:

smoke-tests:
    name: "Build and Smoke tests"
    runs-on: {{ '${{ matrix.os }}' }}
    needs: [code-style]
    strategy:
      fail-fast: false
      matrix:
        os: [ubuntu-latest, windows-latest]
        {% set required_minor = cookiecutter.__requires_python[2:] | int %}
        {%- set python_versions = [ ] -%}
        {%- for minor in range(9, 13) -%}
        {%- if minor >= required_minor -%}
        {{ python_versions.append("3." + minor | string ) or ''}}
        {%- endif -%}
        {%- endfor -%}
        python-version: {{ python_versions }}
    steps:
      - uses: ansys/actions/build-wheelhouse@v6
        with:
          library-name: {{ '${{ env.LIBRARY_NAME }}' }}
          operating-system: {{ '${{ matrix.os }}' }}
          python-version: {{ '${{ matrix.python-version }}' }}

  tests:
    name: "Tests"
    runs-on: {{ '${{ matrix.os }}' }}
    needs: [smoke-tests]

Job smoke-tests only performs action build-wheelhouse, so job should be renamed accordingly into build-wheelhouse to avoid confusion. Then tests updated with needs: [build-wheelhouse].

📝 Steps to reproduce

Create a new project with any template.

💻 Which operating system are you using?

Windows

🐍 Which Python version are you using?

3.10

📦 Installed packages

Does not matter.
@anscfrisson anscfrisson added the bug Something isn't working label Jun 20, 2024
@anscfrisson
Copy link
Author
  • I have searched among the existing issues

https://github.com/search?q=repo%3Aansys%2Fansys-templates+smoke-tests&type=issues yields:

#11 (comment) by @jorgepiloto

Code coverage was introduced in #18. In addition, the CI was parametrized again by splitting smoke and templates tests. Closing this...

But I am not finding matches of smoke-tests in https://github.com/ansys/ansys-templates/pull/18/files

@anscfrisson anscfrisson linked a pull request Jun 20, 2024 that will close this issue
Open
@anscfrisson anscfrisson linked a pull request Jun 20, 2024 that will close this issue
Rename smoke-tests into build-wheelhouse in the common ci_cd.yml template #492
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename smoke-tests into build-wheelhouse in the common ci_cd.yml template ansys/ansys-templates
1 participant
@anscfrisson
0