8000 Rds module fix backport by stefanhorning · Pull Request #57797 · ansible/ansible · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rds module fix backport #57797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2019
Merged

Rds module fix backport #57797

merged 2 commits into from
Jun 18, 2019

Conversation

stefanhorning
Copy link
Contributor
@stefanhorning stefanhorning commented Jun 13, 2019 •
edited
Loading
SUMMARY

Backporting #56220 against stable-2.8 as requested by @s-hertel

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_instance

ADDITIONAL INFORMATION

Fixes #50081

@stefanhorning stefanhorning mentioned this pull request Jun 13, 2019
Merged
@ansibot
Copy link
Contributor
ansibot commented Jun 13, 2019

@stefanhorning, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jun 13, 2019
@s-hertel
Copy link
Contributor

I just want to leave a note - this should wait until #57943 has been merged and can also be cherry-picked.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 17, 2019
stefanhorning and others added 2 commits June 18, 2019 12:04
@stefanhorning @abadger
Fix rds_instance module to run against an (older) existing RDS instan…
e92bec6 
…ce successfully

Only pop Iops param if no storage_type is given. If given and set to wrong type we get to the AWS client error that informs the user

Docs syntax fix

Fix typo in docs

Co-Authored-By: stefanhorning <stefan@hornings.de>

Added changelog fragment for rds_instance bugfix
@willthames @abadger
rds_instance: allow empty iops and storage_type (ansible#57943)
26139b1 
(cherry picked from commit a66687f)
@abadger abadger force-pushed the rds_module_fix_backport branch from 38abc3c to 26139b1 Compare June 18, 2019 19:04
@abadger
Copy link
Contributor
abadger commented Jun 18, 2019

#57943 has been merged. I've added the commit from there to this PR. Will merge once it passes in shippable.

@abadger abadger merged commit 1e5e663 into ansible:stable-2.8 Jun 18, 2019
@abadger
Copy link
Contributor
abadger commented Jun 18, 2019

Merged for the 2.8.2 release.

@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stefanhorning @ansibot @s-hertel @abadger @willthames
0