Fix rds_instance module… #56220
Merged
Fix rds_instance module… #56220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanhorning
commented
May 8, 2019
…wrong type we get to the AWS client error that informs the user
Akasurde
reviewed
May 8, 2019
Co-Authored-By: stefanhorning <stefan@hornings.de>
s-hertel
approved these changes
Jun 7, 2019
|
rebuild_merge |
|
@stefanhorning Do you mind opening a backport PR to 2.8 for this? It will need a changelog fragment. I noticed someone else with one of these problems in #50081. |
|
@stefanhorning Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
… to run against an existing RDS instance successfully
Fixes tow issues I experienced when trying to run this module against an already existing RDS instance (created 2016). See details below.
ISSUE TYPE
COMPONENT NAME
rds_instance module
ADDITIONAL INFORMATION
Fixes two errors (relevant exception snippets):
line 903, in get_current_attributes_with_inconsistent_keys KeyError: 'PerformanceInsightsEnabled'[...]line 948, in get_changing_options_with_consistent_keys KeyError: 'Iops'[...]