8000 feat(cdk/overlay): add disposeOnNavigation by naaajii · Pull Request #27672 · angular/components · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(cdk/overlay): add disposeOnNavigation #27672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

naaajii
Copy link
Contributor
@naaajii naaajii commented Aug 17, 2023

add disposeOnNavigation to overlay directive

fixes #27545

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Aug 17, 2023
@naaajii naaajii marked this pull request as ready for review August 20, 2023 12:36
@naaajii naaajii force-pushed the feat-27545 branch 2 times, most recently from 5058697 to b4108f6 Compare August 24, 2023 13:07
add disposeOnNavigation to overlay directive

fixes angular#27545
@naaajii naaajii requested a review from crisbeto August 24, 2023 14:10
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 24, 2023
@crisbeto crisbeto self-assigned this Aug 24, 2023
Copy link
Member
@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto merged commit b3e4d57 into angular:main Aug 25, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2023
@naaajii naaajii deleted the feat-27545 branch September 27, 2024 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(CdkConnectedOverlay): Add cdkConnectedOverlayDisposeOnNavigation as @Input for the directive
2 participants
0