8000 feat(CdkConnectedOverlay): Add `cdkConnectedOverlayDisposeOnNavigation` as @Input for the directive · Issue #27545 · angular/components · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(CdkConnectedOverlay): Add cdkConnectedOverlayDisposeOnNavigation as @Input for the directive #27545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martendV opened this issue Jul 31, 2023 · 1 comment · Fixed by #27672
Closed

feat(CdkConnectedOverlay): Add cdkConnectedOverlayDisposeOnNavigation as @Input for the directive #27545

martendV opened this issue Jul 31, 2023 · 1 comment · Fixed by #27672
Labels
area: cdk/overlay feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@martendV
Copy link

Feature Description

It would be nice, if cdkConnectedOverlayDisposeOnNavigation could be added as @input parameter for the CdkConnectedOverlay directive.
Adding it could also be a possibility to add other missing properties from the OverlayConfig.

In the following file ...cdk/overlay/overlay-directive.ts a new input @Input('cdkConnectedOverlayDisposeOnNavigation') open: boolean = false; would have to be added and the private _buildConfig(): OverlayConfig method would need modifications to support the new input.

Use Case

Using the CdkConnectedOverlay directive with disposeOnNavigation. The directive produces a significantly smaller overhead than the overlay.create() solution.
@martendV martendV added feature This issue represents a new feature or feature request rather than a bug or bug fix needs triage This issue needs to be triaged by the team labels Jul 31, 2023
@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: cdk/overlay and removed needs triage This issue needs to be triaged by the team labels Aug 1, 2023
naaajii added a commit to naaajii/components that referenced this issue Aug 17, 2023
@naaajii
feat(cdk/overlay): add disposeOnNavigation
a2b6210
8000 
add disposeOnNavigation to overlay directive

fixes angular#27545
@naaajii naaajii mentioned this issue Aug 17, 2023
Merged
naaajii added a commit to naaajii/components that referenced this issue Aug 24, 2023
@naaajii
feat(cdk/overlay): add disposeOnNavigation
5058697 
add disposeOnNavigation to overlay directive

fixes angular#27545
naaajii added a commit to naaajii/components that referenced this issue Aug 24, 2023
@naaajii
feat(cdk/overlay): add disposeOnNavigation
b4108f6 
add disposeOnNavigation to overlay directive

fixes angular#27545
naaajii added a commit to naaajii/components that referenced this issue Aug 24, 2023
@naaajii
feat(cdk/overlay): add disposeOnNavigation
e4227c8 
add disposeOnNavigation to overlay directive

fixes angular#27545
crisbeto pushed a commit that referenced this issue Aug 25, 2023
@naaajii
feat(cdk/overlay): add disposeOnNavigation (#27672)
b3e4d57 
add disposeOnNavigation to overlay directive

fixes #27545
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: cdk/overlay feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cdk/overlay): add disposeOnNavigation naaajii/components
2 participants
@martendV @andrewseguin
0