8000 feat(module:overlay): directive support disposeOnNavigation by wzhudev · Pull Request #18394 · angular/components · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(module:overlay): directive support disposeOnNavigation #18394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(module:overlay): directive support disposeOnNavigation #18394

wants to merge 1 commit into from

Conversation

wzhudev
Copy link
@wzhudev wzhudev commented Feb 5, 2020

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Feb 5, 2020
@wzhudev
Copy link
Author
wzhudev commented Feb 5, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Feb 5, 2020
crisbeto
crisbeto reviewed Feb 5, 2020
View reviewed changes
Copy link
Member
@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this is necessary, because the directive dispose itself in ngOnDestroy which should happen when the route changes as well.

@wzhudev
Copy link
Author
wzhudev commented Feb 5, 2020 •
edited
Loading

@crisbeto Please check this bug of ng-zorro NG-ZORRO/ng-zorro-antd#1530 and this bug of components itself #11478.

But I've not tested them with the latest release of CDK.

@crisbeto
Copy link
Member
crisbeto commented Feb 5, 2020

I don't see where the overlay directive is being used in the linked example.

@wzhudev
Copy link
Author
wzhudev commented Feb 5, 2020 •
edited
Loading

@crisbeto Sorry for the misleading.

Material seems just missing a property here.

But in ng-zorro-antd we use Overlay in a declarative way.

@crisbeto
Copy link
Member
crisbeto commented Feb 5, 2020

That was my point. Wouldn't that component that is used declaratively be destroyed when you navigate to a different route?

@wzhudev
Copy link
Author
wzhudev commented Feb 5, 2020 •
edited
Loading

That was my point. Wouldn't that component that is used declaratively be destroyed when you navigate to a different route?

I am afraid not, according to the reproductions provided in NG-ZORRO/ng-zorro-antd#1530.

The user applied a router reuse strategy here so it seemed that the component is not destroyed?

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@wzhudev wzhudev requested a review from a team as a code owner March 6, 2022 07:04
@josephperrott josephperrott removed the request for review from a team March 7, 2022 17:55
@josephperrott josephperrott added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed needs rebase labels Nov 16, 2022
@crisbeto
Copy link
Member

This was done in #27672. Closing.

@crisbeto crisbeto closed this Feb 28, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wzhudev @googlebot @crisbeto @josephperrott @andrewseguin
0