Article: Everything Github: Continuous Integration, Deployment and Hosting for your Angular App [WIP] #7
Conversation
follow up of #6
|
You can read a preview of the article here: |
|
I'm currently testing to see if the GitHub installation token works. I'll report back if I have any results. It seems that as it turns out, the documentation on the
So it seems that it's safe to use the And from the same documentation I've linked, it seems that: yes, you can use the Here's the full list:
(I'm not sure if the above was relevant, but I've added it just in case) EDIT: It seems that the issue is still prevalent as of today - see this GitHub Community post for more info. |
|
Wow, you're fast! 😄 Thank you so much for your efforts. So that means that the GITHUB_TOKEN now has more rights than before?? Because back then you found out that it doesn't work. (see angular-schule/angular-cli-ghpages#73 (comment)) I will give it a try, too! 🚀 |
@JohannesHoppe Yes, you are right. I have mentioned I will also check about checkout@v2. |
|
@JohannesHoppe I checked with |
|
@JohannesHoppe I also noticed that, in the docs which I wrote for angular-schule, I mentioned this workflow from Angular's website to run e2e tests. But, to run them successfully on Github Actions, we need to follow Angular CLI's wiki doc. To be specific:
|
|
@shhdharmen Are you sure that it actually worked? Did you actually check if the site was actually deployed to GitHub Pages? Or it's probably because the repository that you were testing this on was marked as private? |
|
@shhdharmen And by the way, the wiki doc you've linked is for Angular CLI v6 and older. |
|
@JohannesHoppe Actually, I'd forgotten to mention that the token seems to only work for private repositories. Public repositories won't actually auto-build the newly deployed commit. |
Yes, it was private repo. |
That's true, but if I don't follow web driver instructions, e2e test is failing. I have checked it on a private repo. |
Ah, that explains why it worked. As mentioned in the GitHub Community post I've linked, some users have commented that deploying to GitHub Pages only works if your repository is marked as private. It doesn't seem to work on public repositories though. |
As for that, see angular/angular-cli#16265 for more information. |
In that issue, the developer was trying in local machine. I tried adding |
|
Guys, you're great! Thank you both so much for getting so deeply involved! I think at the moment there's nothing more we can do than to use good-old the GH_TOKEN - because we want to support public repos. I'll add a new paragraph that addresses the new findings regarding GH_TOKEN. More to come soon. 👍 |
|
How do you guys like that? |
I know what you mean but I don't get the sentence structure. Should be simplified. |
|
The GitHub plans section sounds a lot like advertisement. Maybe add a note that you are not affiliated with GitHub in any way but 6D40 that you are a passionate GitHub user and that you recommend the service from your experience. |
|
I'd not mention our VScode extension pack. I think this is useless for everyone outside of our workshops. |
This is a Second-level domain. Didn't want to change this so I'll leave this up to you |
Does not work |
How about simply NOT using this feature for the article then? 😅 This is more confusing than useful here and you could omit this side note completely. |
Mention the source here as those might change. |
I think the term is correct:
Also GitHub calls them subdomains, see this. |
Fair point!
Oops! I added and removed it several times for a nice screenshot! 😅
I agree that this is confusing and I think we need to add a new paragraph for this. One point where Netlify is said to be better is asset optimization: FYI Fur sure, it's not my job to mention a direct competitor. But I hope you see my concerns here. Ok, so after all, the real reason for the Cloudflare CDN is that Github doesn't deliver the assets perfectly. Cloudflare is a necessary additional tool. The bad part: |
"Subdomain" is fine, I was worried about "main domain", never heard this before. https://en.wikipedia.org/wiki/Second-level_domain
I would not start this discussion at all. In a "everything GitHub" article it's perfectly fine to just show the tools provided by GitHub. Maybe mention that asset optimization is not very good at GitHub and tehrefore it is recommended to use some sort of CDN in front of it.
You don't have to! Just say "Please keep in mind that for further optimizations it is recommended to use a CDN as an additional service in front of the hosted website. E.g. Cloudflare does a good job here." Or just skip the SSL termination at cloudflare so you don't need to add the part about why the SSL cert is not issued by GitHub but by Cloudflare. |
|
@fmalcher I'm convinced! 😉 |
4595733 to
c2b1c40
Compare
Co-Authored-By: Dharmen Shah <shhdharmen@gmail.com> everything-github: suggested change by @shhdharmen Co-Authored-By: Dharmen Shah <shhdharmen@gmail.com> everything-github: suggested change by @shhdharmen Co-Authored-By: Dharmen Shah <shhdharmen@gmail.com> everything-github: suggested change by @shhdharmen Co-Authored-By: Dharmen Shah <shhdharmen@gmail.com> everything-github: suggested change by @shhdharmen Co-Authored-By: Dharmen Shah <shhdharmen@gmail.com> everything-github: suggested change by @shhdharmen Co-Authored-By: Dharmen Shah <shhdharmen@gmail.com>
everything-github: new header image
Co-Authored-By: Dharmen Shah <shhdharmen@gmail.com>
c2b1c40 to
8001ef1
Compare
|
Thank you all very much! I will launch the spaceship on Monday! 🚀 |
FYI, I'm still trying to figure out how everything works.
follow up of PR #6
Question to @shhdharmen
In your example, there is no
--repooption? Did you really managed to make this work in real code? This should not work, because angular-cli-ghpages does only add the token via a simple string/replace on the provided parameter. It shouldn't work with the remote of the repository. see this code@EdricChan03
FYI, you might want to get involved as well. I'd appreciate your help. 😃
I'm also a bit of confused if we're really doing the token thing right at all.
see angular-schule/angular-cli-ghpages#73 (comment)