8000 NgRx Data Views by dhhyi · Pull Request #4 · angular-schule/website-articles · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NgRx Data Views #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

NgRx Data Views #4

wants to merge 4 commits into from

Conversation

dhhyi
Copy link
Contributor
@dhhyi dhhyi commented Sep 23, 2019

Hi folks,

@fmalcher said I could write if I felt like it - turns out I did 😁

Please provide feedback, thx,
Danilo

@fmalcher
Copy link
Member

Didn't take a closer look yet, but: Wow! Thank you already, I will provide feedback soon.

@fmalcher
Copy link
Member

No need to change this now, but for the next post: When you put each sentence in a new line, it's easier to review, comment and merge with Git 🙂

< 8000 !-- -->

@fmalcher
Copy link
Member

Wow, I'm impressed! This is exactly as I imagined. For my taste there could be some more elaborate explanations but this is all about who the target audience is. Therefore, it's important to provide guidance at the very beginning and tell the reader what we will talk about and what they should already know.

What you should add is the classification of the idea: Is it just a laboratory idea or is it something you use in a big enterprise app?

Something like:

We've been using this pattern in a big enterprise Angular application for more than a year now. Together with the separation NgRx provides, this idea brought a clean structure to the project. You can always expect the store to contain normalized entities and you always consume nested data in your components. All the necessary mapping happens in between and outside the scope of the component.

This makes a lot more appreciation towards the idea, because people see: "Wow, this is not just some nonsense but those folks tested this in production."

When it comes to me the post should have a few more pictures, however I don't know where yet. 😅
Maybe you should first resolve all my comments and then I do a spell-check and "final" review.
We also need a header image but this is the last step.

Thanks so far! This is going to be a very good article!

// cc @JohannesHoppe

@dhhyi dhhyi force-pushed the gh-pages branch 2 times, most recently from 33d4b96 to 15040d0 Compare November 25, 2019 20:07
@fmalcher
Copy link
Member

@dhhyi I rebased, squashed and merged into gh-pages. You should rebase onto the current gh-pages and work upon there. This way we can already see the live preview and I can make changes, too.
https://angular.schule/blog/2019-12-ngrx-data-views

@fmalcher
Copy link
Member

@fmalcher
Copy link
Member

Did some minor proof reading (see 0d53186), squashed your commits and merged them into gh-pages. If you do any further changes, you should rebase/merge from the current gh-pages.

@JohannesHoppe and I discussed the release date and we agreed that we should release this in the first week of January to avoid the xmas fatigue. I will create the header picture before this.

@fmalcher
Copy link
Member
fmalcher commented Dec 17, 2019

@JohannesHoppe
Copy link
Member

About the cover picture. I would highlight the aspect "other view on the data" or "layers of data".
Two examples:

image
https://pixabay.com/images/id-614974/

image

https://pixabay.com/images/id-3174729/

@JohannesHoppe
Copy link
Member

Now imagine the second image with some cool bold white text on the grey ground. 😍

@dhhyi
Copy link
Contributor Author
dhhyi commented Dec 19, 2019

Now imagine the second image with some cool bold white text on the grey ground.

@JohannesHoppe I would REALLY like to see this background: https://www.dropbox.com/s/6vnddw97x2h8h1e/IMG_20180910_081910.jpg?dl=0

Because it is subtle and inspirational.

Dare to overrule me ;P

@JohannesHoppe
Copy link
Member

Some leaves. I do not see any relation to the topic?? 🤨

@dhhyi
Copy link
Contributor Author
dhhyi commented Dec 23, 2019

Some leaves. I do not see any relation to the topic??

@JohannesHoppe Okay, you're right, there's no direct relation to the topic, other than the leaves giving a blurry glimpse (read "view") of my working place. I thought it would be a nice greeting to my fellow workers, if they recognize it while stumbling upon this article. Also I took that photo and thereby can relate to it. 😉
Additionally there's that: https://www.google.de/search?q=willow+tree+symbolism
It's not just "some leaves" to me.

@fmalcher
Copy link
Member
fmalcher commented Jan 3, 2020

see it in action

Screen Shot 2020-01-03 at 09 26 43

@fmalcher
Copy link
Member
fmalcher commented Jan 3, 2020

Not my personal favourite (I'd prefer a more technical picture as well) but I could live with it ;-)

@JohannesHoppe
Copy link
Member

😕

@dhhyi
Copy link
Contributor Author
dhhyi commented Jan 3, 2020

Awesome. Looks great. Thanks 🙂 👍

@dhhyi
Copy link
Contributor Author < EFC8 /div>
dhhyi commented Jan 3, 2020

One thing I still forgot: Fix the "NEW" label in the demo application so it marks the latest book as new in 2020. 😅 I'll be right on it.

@dhhyi
Copy link
Contributor Author
dhhyi commented Jan 3, 2020

I'll be right on it.

Done 👍

@fmalcher
Copy link
Member
fmalcher commented Jan 3, 2020

Done 👍

You updated the Stackblitz example only and not the text, right? So nothing to do for me here?

@dhhyi
Copy link
Contributor Author
dhhyi commented Jan 3, 2020

You updated the Stackblitz example only and not the text, right? So nothing to do for me here?

Right. Now everything is working again and if you want you can fork the examples on StackBlitz. You can also leave it like it is now, I won't delete the demo repo 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0