10000 signalPublish with not STANDALONE_MODE by luoxn28 · Pull Request #810 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

signalPublish with not STANDALONE_MODE #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2019
Merged

signalPublish with not STANDALONE_MODE #810

merged 2 commits into from
Feb 28, 2019

Conversation

luoxn28
Copy link
Contributor
@luoxn28 luoxn28 commented Feb 21, 2019

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

signalPublish with !STANDALONE_MODE on publish data to other servers.

Brief changelog

if (!STANDALONE_MODE && !latch.await(UtilsAndCommons.RAFT_PUBLISH_TIMEOUT, TimeUnit.MILLISECONDS))

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@xuechaos xuechaos changed the base branch from master to develop February 28, 2019 06:14
@nkorange nkorange merged commit 1e1e1be into alibaba:develop Feb 28, 2019
@nacos-bot nacos-bot mentioned this pull request Mar 1, 2019
Closed
KiteSoar pushed a commit to KiteSoar/nacos that referenced this pull request Mar 1, 2025
@xpy01xpy
Update ding (alibaba#810)
b3a400e 
* Load cnpliot by width

* Bottom up

* update ding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkorange nkorange nkorange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luoxn28 @nkorange
0