8000 Fix #762 by nkorange · Pull Request #763 · alibaba/nacos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix #762 #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fix #762 #763

merged 1 commit into from
Feb 14, 2019

Conversation

nkorange
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Brief changelog

#762

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@nkorange nkorange requested a review from JianweiWang February 14, 2019 08:14
@nkorange nkorange merged commit 1043f85 into master Feb 14, 2019
@nacos-bot nacos-bot mentioned this pull request Feb 15, 2019
Closed
@KomachiSion KomachiSion deleted the hotfix_standalone_register_failed branch June 17, 2020 07:45
KiteSoar pushed a commit to KiteSoar/nacos that referenced this pull request Mar 1, 2025
@fuhouyu
UPDATE parameters-check.md 实例元数据注释 (alibaba#763)
10c2966 
* update parameters-check.md 实例元数据

* fixed 多余符号
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JianweiWang JianweiWang Awaiting requested review from JianweiWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nkorange
0