-
Notifications
You must be signed in to change notification settings - Fork 383
feat: Add unified x86 / aarch64 (ARM) build for VLLM image #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m install for now
VLLM ARM build/install from source added in separate PR here for easier isolation of logical changes: #845 |
nv-anants
reviewed
Apr 28, 2025
8000
…rk vllm to run command to match
nv-anants
approved these changes
Apr 28, 2025
Sanity test Example # Start container
./container/run.sh -it --image gitlab-master.nvidia.com:5005/dl/ai-dynamo/dynamo-ci/rmccormick:dynamo_6084b0f_vllm0.8.4_aarch64
# Starts nats/etcd
nats-server -js &
etcd --listen-client-urls http://0.0.0.0:2379 --advertise-client-urls http://0.0.0.0:2379 &
# Serve
cd /workspace/examples/llm
dynamo serve graphs.agg:Frontend -f configs/agg.yaml & Example request: MODEL=${MODEL:-"deepseek-ai/DeepSeek-R1-Distill-Llama-8B"}
curl localhost:8000/v1/chat/completions -H "Content-Type: application/json" -d '{
"model": "'${MODEL}'",
"messages": [
{
"role": "user",
"content": "In the heart of Eldoria, an ancient land of boundless magic and mysterious creatures, lies the long-forgotten city of Aeloria. Once a beacon of knowledge and power, Aeloria was buried beneath the shifting sands of time, lost to the world for centuries. You are an intrepid explorer, known for your unparalleled curiosity and courage, who has stumbled upon an ancient map hinting at ests that Aeloria holds a secret so profound that it has the potential to reshape the very fabric of reality. Your journey will take you through treacherous deserts, enchanted forests, and across perilous mountain ranges. Your Task: Character Background: Develop a detailed background for your character. Describe their motivations for seeking out Aeloria, their skills and weaknesses, and any personal connections to the ancient city or its legends. Are they driven by a quest for knowledge, a search for lost familt clue is hidden."
}
],
"stream":false,
"max_tokens": 30
}' Output
|
rmccorm4
added a commit
that referenced
this pull request
Apr 28, 2025
saturley-hall
pushed a commit
that referenced
this pull request
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Parameterizes ARCH for x86/arm installs of etcd, nats, dynamo, and NIXL, similar to #803
Extends NIXL install from #594 with ARM support.
VLLM ARM build/install from source added in separate PR here for easier isolation of changes, but merged into this PR: #845
Manually tested with following builds (minimal runtime testing).
x86
ARM
Minimal runtime validation of vllm/torch installs after: #845
Needs follow-up: (@saturley-hall @nv-anants)
ai_dynamo_vllm
, similar to how it's done in the x86 download+patch+publish path:dynamo/container/Dockerfile.vllm
Lines 127 to 130 in 6084b0f
vllm
instead ofai_dynamo_vllm
on ARM only: