build: remove dependency install for nixl #594
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependencies are already present as part of cuda-dl-base image
f4ecb71 to
57962dd
Compare
nnshah1
reviewed
Apr 11, 2025
Signed-off-by: Tim Stamler <tstamler@nvidia.com>
nv-anants
commented
Apr 24, 2025
Signed-off-by: Tim Stamler <tstamler@nvidia.com>
|
are we concentrating on this request or this one: |
this one. closed 407 |
rmccorm4
reviewed
Apr 26, 2025
| @@ -182,6 +73,9 @@ RUN mkdir /opt/dynamo && \ | |||
| ENV VIRTUAL_ENV=/opt/dynamo/venv | |||
| ENV PATH="${VIRTUAL_ENV}/bin:${PATH}" | |||
|
|
|||
| # Install NIXL Python module | |||
| RUN cd /opt/nixl && uv pip install . | |||
There was a problem hiding this comment.
For ARM support it looks like we need to set gds_path explicitly because it's hard-coded on nixl side atm. This worked for me on a quick test until we can move the arch detection to NIXL side:
# Install NIXL Python module
# TODO: Can NIXL build select gds_path based on arch instead of us?
RUN if [ "$ARCH" = "arm64" ]; then \
cd /opt/nixl && uv pip install . --config-settings=setup-args="-Dgds_path=/usr/local/cuda/targets/sbsa-linux/"; \
else \
cd /opt/nixl && uv pip install .; \
fiThere was a problem hiding this comment.
This PR looks great to me otherwise!
This was referenced Apr 26, 2025
|
I've included and extended this PR with ARM support in this PR: #839 |
Signed-off-by: Anant Sharma <anants@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Dependencies are already present as part of cuda-dl-base image
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)