8000 Try to reduce CI flakiness by luca-della-vedova · Pull Request #103 · osrf/nexus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Try to reduce CI flakiness #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

luca-della-vedova
Copy link
Member

No description provided.

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@luca-della-vedova
Copy link
Member Author

It seems the parallel RMF pick and place test is quite flaky, as shown the first commit fails three tries in a row, the second commit succeeds on the first try. One of the reasons is a possibility of AMRs getting stuck in the tight space but there might be other reasons I haven't managed to identify yet.
My proposal would be to remove this test first

@luca-della-vedova luca-della-vedova marked this pull request as ready for review June 30, 2025 08:42
@Yadunund Yadunund requested a review from aaronchongth June 30, 2025 20:37
@@ -1,135 +0,0 @@
# Copyright (C) 2025 Open Source Robotics Foundation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just rename this test to test_parallel_pick_and_place_rmf.py.disabled, unittest will not pick this file up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0