Indicate dirty in mstatus.FS correctly #2936
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cea756e to
126e2d1
Compare
|
❌ failed run, report available here. |
Gchauvon
approved these changes
Apr 18, 2025
|
❌ failed run, report available here. |
0b7bd65 to
8df9042
Compare
|
Rebased to master. |
|
❌ failed run, report available here. |
1 similar comment
|
❌ failed run, report available here. |
8000
WorldofJARcraft
force-pushed
the
fpu-dirty-fix
branch
2 times, most recently
from
April 25, 2025 16:51
97be8d4 to
8b8ad91
Compare
|
❌ failed run, report available here. |
1 similar comment
|
❌ failed run, report available here. |
|
Thanks for the contribution. |
f251cb0 to
a2b1b30
Compare
|
@JeanRochCoulon I have rebased the branch. |
|
❌ failed run, report available here. |
This commit makes two changes to the commit stage: - It fixes incorrect parenthesis, causing dirty_fp_state_o not to be set on floating point instructions such as fld. - It adds a condition for dirty_fp_state_o that only asserts the flag for floating point instructions that change any FPU registers.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Guillaume Chauvon <94678394+Gchauvon@users.noreply.github.com>
a2b1b30 to
e95a980
Compare
|
❌ failed run, report available here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes two changes to the commit stage:
This PR fixes #2934