logging: Fix missing logging #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we started using logging before it had been initialized. Which resulted in leapp stopping to log for some logger names the debug output. We did not know why this happened. It turns out that fileConfig from the logging library has a parameter disable_existing_loggers which is by default set to True and will set all loggers that have existed before the call to fileConfig to disabled. Which in turn will make them stop logging of course. This patch will change this behaviour and set disable_existing_loggers to False in order to have existing loggers be still enabled. Signed-off-by: Vinzenz Feenstra <vfeenstr@redhat.com>
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
Rezney
approved these changes
Mar 10, 2022
|
/rerun |
|
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3665300 |
|
Testing Farm request for 7to8/3653299,3665300 regression testing has been created. Once finished, results should be available here. |
|
Testing Farm request for 8to9/3653299,3665300 regression testing has been created. Once finished, results should be available here. |
Merged
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Mar 17, 2022
## Packaging - Add depency on `python3` for el8+ (`python3` refers to the distribution python) - Bump `leapp-framework` to 2.2 - Bump `leapp-framework-dependencies` to 6 - Doc: --report-schema in manpage (oamg#686) ## Framework ### Fixes - Fix issues with initialisation of loggers (oamg#764) - Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760) - Prevent breaking the answerfile when dialog fields contain newlines (oamg#757) - Check answerfile upon loading (oamg#759) - Fix the multiprocessing on Python 3.9 on Mac OS ### Enhancements - Dialogs: print the reason field for question in the answerfile (oamg#762) - Added possibility to specify the report format version (oamg#686) ## stdlib ### Enhancements - Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
pirat89
pushed a commit
to Rezney/leapp
that referenced
this pull request
Mar 18, 2022
## Packaging - Add depency on `python3` for el8+ (`python3` refers to the distribution python) - Bump `leapp-framework` to 2.2 - Bump `leapp-framework-dependencies` to 6 - Doc: --report-schema in manpage (oamg#686) ## Framework ### Fixes - Fix issues with initialisation of loggers (oamg#764) - Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760) - Prevent breaking the answerfile when dialog fields contain newlines (oamg#757) - Check answerfile upon loading (oamg#759) - Fix the multiprocessing on Python 3.9 on Mac OS ### Enhancements - Dialogs: print the reason field for question in the answerfile (oamg#762) - Added possibility to specify the report format version (oamg#686) ## stdlib ### Enhancements - Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
Rezney
added a commit
to Rezney/leapp
that referenced
this pull request
Mar 18, 2022
## Packaging - Add depency on `python3` for el8+ (`python3` refers to the distribution python) - Bump `leapp-framework` to 2.2 - Bump `leapp-framework-dependencies` to 6 - Doc: --report-schema in manpage (oamg#686) ## Framework ### Fixes - Fix issues with initialisation of loggers (oamg#764) - Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760) - Prevent breaking the answerfile when dialog fields contain newlines (oamg#757) - Check answerfile upon loading (oamg#759) - Fix the multiprocessing on Python 3.9 on Mac OS ### Enhancements - Dialogs: print the reason field for question in the answerfile (oamg#762) - Added possibility to specify the report format version (oamg#686) ## stdlib ### Enhancements - Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
pirat89
pushed a commit
that referenced
this pull request
Mar 18, 2022
## Packaging - Add depency on `python3` for el8+ (`python3` refers to the distribution python) - Bump `leapp-framework` to 2.2 - Bump `leapp-framework-dependencies` to 6 - Doc: --report-schema in manpage (#686) ## Framework ### Fixes - Fix issues with initialisation of loggers (#764) - Fix TypeError during JSON serialization in dialogs on Python3 (#760) - Prevent breaking the answerfile when dialog fields contain newlines (#757) - Check answerfile upon loading (#759) - Fix the multiprocessing on Python 3.9 on Mac OS ### Enhancements - Dialogs: print the reason field for question in the answerfile (#762) - Added possibility to specify the report format version (#686) ## stdlib ### Enhancements - Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (#742)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we started using logging before it had been initialized.
Which resulted in leapp stopping to log for some logger names the debug
output. We did not know why this happened. It turns out that fileConfig
from the logging library has a parameter disable_existing_loggers which
is by default set to True and will set all loggers that have existed
before the call to fileConfig to disabled. Which in turn will make them
stop logging of course.
This patch will change this behaviour and set disable_existing_loggers
to False in order to have existing loggers be still enabled.
Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com