8000 Fix store of answers on Python3.6 (DictProxy) by pirat89 · Pull Request #759 · oamg/leapp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix store of answers on Python3.6 (DictProxy) #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix store of answers on Python3.6 (DictProxy) #759

wants to merge 1 commit into from

Conversation

pirat89
Copy link
Member
@pirat89 pirat89 commented Feb 25, 2022

On Python3 the loaded answer is "sometimes" represented by DictProxy
object. In such a case the answer cannot be serialized into the
JSON object and storing into the audit db fails with crash.

"sometimes" ==> I have a suspicion the result is different in case
the answer is loaded from the answerfile and
userchoices file.

See: oamg/leapp-repository#821

Note: This is not a proper fix. I am sending the commit from a train
with unstable network.

@pirat89
Fix store of answers on Python3.6 (DictProxy)
4e23eb1 
On Python3 the loaded answer is "sometimes" represented by DictProxy
object. In such a case the answer cannot be serialized into the
JSON object and storing into the audit db fails with crash.

"sometimes" ==> I have a suspicion the result is different in case
                the answer is loaded from the answerfile and
                userchoices file.

See: oamg/leapp-repository#821

Note: This is not a proper fix. I am sending the commit from a train
      with unstable network.
@github-actions
Copy link

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run copr build and e2e tests in OAMG CI
  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@centos-ci
Copy link

Can one of the admins verify this patch?

@fernflower
Copy link
Member

I'd say this is the proper fix #760

@pirat89
Copy link
Member Author
pirat89 commented Feb 25, 2022

Closing it in favor of #760

btw, I am hitting it now in 100% cases on Py3 with dialogs. I have no idea how I passed through it earlier this day when the dialog has been raised. the object is DictProxy all the time the question is answered.

@pirat89 pirat89 closed this Feb 25, 2022
@pirat89 pirat89 mentioned this pull request Mar 15, 2022
Merged
pirat89 added a commit to pirat89/leapp that referenced this pull request Mar 17, 2022
@pirat89
# Release 0.14.0
ce78794 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (oamg#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (oamg#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760)
- Prevent breaking the answerfile when dialog fields contain newlines (oamg#757)
- Check answerfile upon loading (oamg#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (oamg#762)
- Added possibility to specify the report format version (oamg#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
pirat89 pushed a commit to Rezney/leapp that referenced this pull request Mar 18, 2022
@Rezney @pirat89
Release 0.14.0
92feec5 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (oamg#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (oamg#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760)
- Prevent breaking the answerfile when dialog fields contain newlines (oamg#757)
- Check answerfile upon loading (oamg#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (oamg#762)
- Added possibility to specify the report format version (oamg#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
Rezney added a commit to Rezney/leapp that referenced this pull request Mar 18, 2022
@Rezney
Release 0.14.0
2d96d91 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (oamg#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (oamg#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (oamg#760)
- Prevent breaking the answerfile when dialog fields contain newlines (oamg#757)
- Check answerfile upon loading (oamg#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (oamg#762)
- Added possibility to specify the report format version (oamg#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (oamg#742)
pirat89 pushed a commit that referenced this pull request Mar 18, 2022
@Rezney @pirat89
Release 0.14.0
d3c38f5 
## Packaging

- Add depency on `python3` for el8+ (`python3` refers to the distribution python)
- Bump `leapp-framework` to 2.2
- Bump `leapp-framework-dependencies` to 6
- Doc: --report-schema in manpage (#686)

## Framework
### Fixes

- Fix issues with initialisation of loggers (#764)
- Fix TypeError during JSON serialization in dialogs on Python3 (#760)
- Prevent breaking the answerfile when dialog fields contain newlines (#757)
- Check answerfile upon loading (#759)
- Fix the multiprocessing on Python 3.9 on Mac OS

### Enhancements

- Dialogs: print the reason field for question in the answerfile (#762)
- Added possibility to specify the report format version (#686)

## stdlib

### Enhancements
- Introduced `stdlib.path` library `get_common_*_path` functions for the scanning repositories, actors, etc. paths outside of the actor execution (#742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzenz vinzenz Awaiting requested review from vinzenz

@fernflower fernflower Awaiting requested review from fernflower

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pirat89 @centos-ci @fernflower
0