8000 refactor(ast): shorten generated code for `VisitMut` by overlookmotel · Pull Request #8795 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(ast): shorten generated code for VisitMut #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

refactor(ast): shorten generated code for VisitMut #8795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions crates/oxc_ast/src/generated/visit_mut.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,7 +1371,7 @@ pub mod walk_mut {

#[inline]
pub fn walk_directives<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, Directive<'a>>) {
for el in it.iter_mut() {
for el in it {
visitor.visit_directive(el);
}
}
Expand All @@ -1395,7 +1395,7 @@ pub mod walk_mut {

#[inline]
pub fn walk_statements<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, Statement<'a>>) {
for el in it.iter_mut() {
for el in it {
visitor.visit_statement(el);
}
}
Expand Down Expand Up @@ -1610,7 +1610,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TemplateElement<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_template_element(el);
}
}
Expand All @@ -1629,7 +1629,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, Expression<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_expression(el);
}
}
Expand Down Expand Up @@ -1691,7 +1691,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, ArrayExpressionElement<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_array_expression_element(el);
}
}
Expand Down Expand Up @@ -1777,7 +1777,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSTypeParameter<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_type_parameter(el);
}
}
Expand Down Expand Up @@ -2028,7 +2028,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, FormalParameter<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_formal_parameter(el);
}
}
Expand All @@ -2048,7 +2048,7 @@ pub mod walk_mut {

#[inline]
pub fn walk_decorators<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, Decorator<'a>>) {
for el in it.iter_mut() {
for el in it {
visitor.visit_decorator(el);
}
}
Expand Down Expand Up @@ -2101,7 +2101,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, BindingProperty<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_binding_property(el);
}
}
Expand Down Expand Up @@ -2281,7 +2281,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSImportAttribute<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_import_attribute(el);
}
}
Expand Down Expand Up @@ -2322,7 +2322,7 @@ pub mod walk_mut {

#[inline]
pub fn walk_ts_types<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, TSType<'a>>) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_type(el);
}
}
Expand Down Expand Up @@ -2487,7 +2487,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSTupleElement<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_tuple_element(el);
}
}
Expand All @@ -2506,7 +2506,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSSignature<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_signature(el);
}
}
Expand Down Expand Up @@ -2542,7 +2542,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSIndexSignatureName<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_index_signature_name(el);
}
}
Expand Down Expand Up @@ -3041,7 +3041,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, AssignmentTargetProperty<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_assignment_target_property(el);
}
}
Expand Down Expand Up @@ -3125,7 +3125,7 @@ pub mod walk_mut {

#[inline]
pub fn walk_arguments<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, Argument<'a>>) {
for el in it.iter_mut() {
for el in it {
visitor.visit_argument(el);
}
}
Expand Down Expand Up @@ -3195,7 +3195,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSClassImplements<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_class_implements(el);
}
}
Expand Down Expand Up @@ -3229,7 +3229,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, ClassElement<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_class_element(el);
}
}
Expand Down Expand Up @@ -3425,7 +3425,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, ObjectPropertyKind<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_object_property_kind(el);
}
}
Expand Down Expand Up @@ -3642,7 +3642,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, JSXAttributeItem<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_jsx_attribute_item(el);
}
}
Expand Down Expand Up @@ -3737,7 +3737,7 @@ pub mod walk_mut {

#[inline]
pub fn walk_jsx_children<'a, V: VisitMut<'a>>(visitor: &mut V, it: &mut Vec<'a, JSXChild<'a>>) {
for el in it.iter_mut() {
for el in it {
visitor.visit_jsx_child(el);
}
}
Expand Down Expand Up @@ -3861,7 +3861,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, VariableDeclarator<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_variable_declarator(el);
}
}
Expand Down Expand Up @@ -3991,7 +3991,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, SwitchCase<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_switch_case(el);
}
}
Expand Down Expand Up @@ -4137,7 +4137,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSInterfaceHeritage<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_interface_heritage(el);
}
}
Expand Down Expand Up @@ -4187,7 +4187,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, TSEnumMember<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_ts_enum_member(el);
}
}
Expand Down Expand Up @@ -4364,7 +4364,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, ImportDeclarationSpecifier<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_import_declaration_specifier(el);
}
}
Expand Down Expand Up @@ -4447,7 +4447,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, ImportAttribute<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_import_attribute(el);
}
}
Expand Down Expand Up @@ -4551,7 +4551,7 @@ pub mod walk_mut {
visitor: &mut V,
it: &mut Vec<'a, ExportSpecifier<'a>>,
) {
for el in it.iter_mut() {
for el in it {
visitor.visit_export_specifier(el);
}
}
Expand Down
3 changes: 1 addition & 2 deletions tasks/ast_tools/src/generators/visit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,9 @@ impl<'a> VisitBuilder<'a> {

let (walk_body, may_inline) = if collection {
let singular_visit = self.get_visitor(def, false);
let iter = if self.is_mut { quote!(it.iter_mut()) } else { quote!(it) };
(
quote! {
for el in #iter {
for el in it {
visitor.#singular_visit(el);
}
},
Expand Down
Loading
0