8000 refactor(ast): shorten generated code for `VisitMut` by overlookmotel · Pull Request #8795 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(ast): shorten generated code for VisitMut #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

refactor(ast): shorten generated code for VisitMut #8795

merged 1 commit into from
Jan 31, 2025

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented Jan 31, 2025 •
edited
Loading

for x in vec.iter_mut() is unnecessarily long - for x in vec works just as well.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 31, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review January 31, 2025 00:53
@overlookmotel
Copy link
Contributor Author
overlookmotel commented Jan 31, 2025 •
edited
Loading

This is a small preparatory step for a large overhaul of oxc_ast_tools (which I'm working on) and makes no difference to behavior. So merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2025
@overlookmotel Graphite App
Copy link
Contributor Author
overlookmotel commented Jan 31, 2025 •
edited by graphite-app bot
Loading
8000

Merge activity

  • Jan 30, 7:58 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 30, 7:58 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 30, 8:03 PM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel
refactor(ast): shorten generated code for VisitMut (#8795)
87a7711 
`for x in vec.iter_mut()` is unnecessarily long - `for x in vec` works just as well.
@graphite-app graphite-app bot force-pushed the 01-31-refactor_ast_shorten_generated_code_for_visitmut_ branch from af23648 to 87a7711 Compare January 31, 2025 00:58
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jan 31, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8795 will not alter performance

Comparing 01-31-refactor_ast_shorten_generated_code_for_visitmut_ (87a7711) with main (70ad879)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot merged commit 87a7711 into main Jan 31, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-31-refactor_ast_shorten_generated_code_for_visitmut_ branch January 31, 2025 01:03
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel
0