8000 fix(linter): fix panic when doing code gen on regexp by camc314 · Pull Request #10769 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(linter): fix panic when doing code gen on regexp #10769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

fix(linter): fix panic when doing code gen on regexp #10769

merged 1 commit into from
May 3, 2025

Conversation

camc314
Copy link
Contributor
@camc314 camc314 commented May 2, 2025 •
edited
Loading

fixes the panic in #10765 by providing the source text of the program to the code generator

@camc314 camc314 mentioned this pull request May 2, 2025
Merged
@github-actions github-actions bot added the A-linter Area - Linter label May 2, 2025
@camc314 Graphite App
Copy link
Contributor Author
camc314 commented May 2, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphit 8000 e Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label May 2, 2025
@camc314 camc314 marked this pull request as ready for review May 2, 2025 16:05
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 2, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10769 will create unknown performance changes

Comparing c/05-02-fix_linter_fix_panic_when_doing_code_gen_on_regexp (8c499c6) with main (2d13b49)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.2 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 715.9 ms N/A
🆕 formatter[react.development.js] N/A 8.1 ms N/A
🆕 formatter[typescript.js] N/A 1.1 s N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.3 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[checker.ts] N/A 14.4 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3.1 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 293.5 µs N/A
🆕 mangler[typescript.js] N/A 39.5 ms N/A
🆕 minifier[antd.js] N/A 163.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 287.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camc314 camc314 mentioned this pull request May 2, 2025
Merged
Sysix
Sysix approved these changes May 2, 2025
View reviewed changes
Copy link
Member
@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good! I do not know about the Codegen PR and do not want to approve something out of my scope :)

@camc314 camc314 force-pushed the c/05-02-feat_codegen_expose_with_source_text_function branch from 493b630 to fece43f Compare May 2, 2025 23:13
@camc314 camc314 force-pushed the c/05-02-fix_linter_fix_panic_when_doing_code_gen_on_regexp branch from 056a8f0 to b882332 Compare May 2, 2025 23:13
@camc314 camc314 changed the base branch from c/05-02-feat_codegen_expose_with_source_text_function to graphite-base/10769 May 2, 2025 23:35
@camc314 camc314 force-pushed the c/05-02-fix_linter_fix_panic_when_doing_code_gen_on_regexp branch from b882332 to d01f3fd Compare May 2, 2025 23:36
@camc314 camc314 force-pushed the graphite-base/10769 branch from fece43f to 3eb558b Compare May 2, 2025 23:36
@camc314 camc314 changed the base branch from graphite-base/10769 to c/05-02-feat_codegen_expose_with_source_text_function May 2, 2025 23:36
@github-actions github-actions bot added the A-codegen Area - Code Generation label May 2, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue 8000 label May 3, 2025
@Boshen Graphite App
Copy link
Member
Boshen commented May 3, 2025 •
edited by graphite-app bot
Loading

Merge activity

@camc314
fix(linter): fix panic when doing code gen on regexp (#10769)
8c499c6 
fixes the panic in #10765 by providing the source text of the program to the code generator
@graphite-app graphite-app bot force-pushed the c/05-02-feat_codegen_expose_with_source_text_function branch from 3eb558b to 2d13b49 Compare May 3, 2025 00:31
@graphite-app graphite-app bot force-pushed the c/05-02-fix_linter_fix_panic_when_doing_code_gen_on_regexp branch from d01f3fd to 8c499c6 Compare May 3, 2025 00:32
Base automatically changed from c/05-02-feat_codegen_expose_with_source_text_function to main May 3, 2025 00:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 3, 2025
@graphite-app graphite-app bot merged commit 8c499c6 into main May 3, 2025
27 checks passed
@graphite-app graphite-app bot deleted the c/05-02-fix_linter_fix_panic_when_doing_code_gen_on_regexp branch May 3, 2025 00:38
@oxc-bot oxc-bot mentioned this pull request May 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camchenry camchenry camchenry approved these changes

@Sysix Sysix Sysix approved these changes

Assignees
No one assigned
Labels
A-codegen Area - Code Generation A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camc314 @Boshen @camchenry @Sysix
0