8000 feat(codegen): expose `with_source_text` function by camc314 · Pull Request #10768 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(codegen): expose with_source_text function #10768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

feat(codegen): expose with_source_text function #10768

merged 1 commit into from
May 3, 2025

Conversation

camc314
Copy link
Contributor
@camc314 camc314 commented May 2, 2025 •
edited
Loading

it is unsafe to call print_expression as the source text may be empty. in this case, the end user would experience panics when printing certain expressions, as it requires referencing the source text

@github-actions github-actions bot added the A-codegen Area - Code Generation label May 2, 2025
@camc314 Graphite App
Copy link
Contributor Author
camc314 commented May 2, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label May 2, 2025
@camc314 camc314 mentioned this pull request May 2, 2025
Merged
@camc314 camc314 marked this pull request as ready for review May 2, 2025 16:05
@camc314 camc314 mentioned this pull request May 2, 2025
Merged
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 2, 2025 •
edited
Loading

Walkthrough

A new public method with_source_text was added to the Codegen struct in the crates/oxc_codegen/src/lib.rs file. This method allows setting the internal source_text field by passing a string slice (&'a str) and returns the updated instance in a builder-style pattern. The print_expression method was updated with a documentation note indicating that with_source_text must be called before invoking it. No other changes to logic, control flow, or the public API were introduced.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3eb558b and 2d13b49.

📒 Files selected for processing (1)
  • crates/oxc_codegen/src/lib.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/oxc_codegen/src/lib.rs
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: Benchmark (formatter)
  • GitHub Check: Conformance
  • GitHub Check: Benchmark (codegen)
  • GitHub Check: Benchmark (minifier)
  • GitHub Check: Benchmark (semantic)
  • GitHub Check: Benchmark (isolated_declarations)
  • GitHub Check: Clippy
  • GitHub Check: Benchmark (transformer)
  • GitHub Check: Test NAPI
  • GitHub Check: Build Linter Benchmark
  • GitHub Check: Benchmark (parser)
  • GitHub Check: Test (macos-latest)
  • GitHub Check: Benchmark (lexer)
  • GitHub Check: Test (ubuntu-latest)
  • GitHub Check: Test wasm32-wasip1-threads
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 2, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10768 will not alter performance

Comparing c/05-02-feat_codegen_expose_with_source_text_function (2d13b49) with main (2efe3f0)

Summary

✅ 36 untouched benchmarks

@camc314 camc314 force-pushed the c/05-02-feat_codegen_expose_with_source_text_function branch 2 times, most recently from fece43f to 3eb558b Compare May 2, 2025 23:35
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 3, 2025
@graphite-app Graphite App
Copy link
graphite-app bot commented May 3, 2025 •
edited
Loading

Merge activity

@camc314
< 8000 a title="feat(codegen): expose `with_source_text` function (#10768) it is unsafe to call `print_expression` as the source text may be empty. in this case, the end user would experience panics when printing certain expressions, as it requires referencing the source text" data-pjax="true" class="Link--secondary markdown-title" href="/oxc-project/oxc/pull/10768/commits/2d13b49216df62dff35bc88e6fd4c1d81134506d">feat(codegen): expose with_source_text function (#10768)
2d13b49 
it is unsafe to call `print_expression` as the source text may be empty. in this case, the end user would experience panics when printing certain expressions, as it requires referencing the source text
@graphite-app graphite-app bot force-pushed the c/05-02-feat_codegen_expose_with_source_text_function branch from 3eb558b to 2d13b49 Compare May 3, 2025 00:31
@graphite-app graphite-app bot merged commit 2d13b49 into main May 3, 2025
26 checks passed
@graphite-app graphite-app bot deleted the c/05-02-feat_codegen_expose_with_source_text_function branch May 3, 2025 00:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 3, 2025
@oxc-bot oxc-bot mentioned this pull request May 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camchenry camchenry camchenry approved these changes

Assignees
No one assigned
Labels
A-codegen Area - Code Generation C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camc314 @camchenry
0