8000
Mermaid v11 #7964
Merged
Mermaid v11 #7964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
commented
Nov 16, 2024
| }, | ||
| renderElement | ||
| // If the element is not visible we use an off-screen element to render the diagram | ||
| element.offsetParent === null ? renderElement : element |
There was a problem hiding this comment.
I wish this wasn't needed, but Mermaid's API is quite strange here – if you don't pass the existing element with rendered content you'll often get an empty SVG returned from the promise, this must be a bug that's being worked around here.
Closed
tommoor
added a commit
that referenced
this pull request
Nov 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally Mermaid seems to bundle correctly, notably while the overall JS size has increased a lot (expected) the initial JS size is reduced with this upgrade and that's much more important.
Supercedes #7865
closes #6798
closes #7815
closes #7815
closes #7791
closes #7228
closes #7199
closes #6470