8000 Update mermaid to V11 by Shuttleu · Pull Request #7865 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update mermaid to V11 #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update mermaid to V11 #7865

wants to merge 1 commit into from

Conversation

Shuttleu
Copy link
Contributor

Update Mermaid to V11 to add latest changes and graphs

@tommoor
Copy link
Member
tommoor commented Oct 29, 2024

The bundle size increase reveals why this upgrade has not been made - this single dependency upgrade increases the size of the entire software by 20%, which is unacceptable

@devinnovqube
Copy link

The bundle size increase reveals why this upgrade has not been made - this single dependency upgrade increases the size of the entire software by 20%, which is unacceptable

Some of the new mermaid features are indeed useful. However, 20% of the size for a few features seems quite substantial. Perhaps we could find a way to allow users to choose between version 9 and version 11 when deploying the application.

Mermaid is regularly improving, and this could certainly become an issue in the future.

@tommoor tommoor mentioned this pull request Nov 16, 2024
Merged
@tommoor
Copy link
Member
tommoor commented Nov 16, 2024

I added additional fixes and merged here #7964

@tommoor tommoor closed this Nov 16, 2024
@owanio1992
Copy link
owanio1992 8000 commented Nov 17, 2024

@tommoor
it's happy to see upgrade mermaid version
I have a little question here
does this cdn link don't need upgrade ?
https://github.com/outline/outline/blob/main/server/models/helpers/ProsemirrorHelper.tsx#L561

@tommoor
Copy link
Member
tommoor commented Nov 17, 2024

Good call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor Awaiting requested review from tommoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shuttleu @tommoor @devinnovqube @owanio1992
0