8000 fix: Shared url and dashboard url corrections by pranavxc · Pull Request #9999 · nocodb/nocodb · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Shared url and dashboard url corrections #9999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: Shared url and dashboard url corrections #9999

merged 1 commit into from
Dec 9, 2024

Conversation

pranavxc
Copy link
Member
@pranavxc pranavxc commented Dec 9, 2024

Change Summary

Provide summary of changes with issue number if any.

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 9, 2024
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Dec 9, 2024 •
edited
Loading

Warning

Rate limit exceeded

@dosubot[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 25 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 699f572 and f3cbf75.

📒 Files selected for processing (3)
  • packages/nc-gui/components/dlg/share-and-collaborate/ShareBase.vue (1 hunks)
  • packages/nc-gui/components/dlg/share-and-collaborate/SharePage.vue (2 hunks)
  • packages/nocodb/src/run/cloud.ts (1 hunks)
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough

Walkthrough

The changes in this pull request involve modifications to the URL handling logic in the ShareBase.vue and SharePage.vue components, removing the getBaseUrl function and directly utilizing the dashboardUrl. Additionally, a new routing condition is introduced in cloud.ts to handle dynamic redirection for the /dashboard endpoint based on the NC_DASHBOARD_URL environment variable. The overall control flow and error handling mechanisms in the components remain unchanged.

Changes

File Path Change Summary
packages/nc-gui/components/dlg/share-and-collaborate/ShareBase.vue Removed getBaseUrl function; simplified URL construction using dashboardUrl; removed workspaceStore.
packages/nc-gui/components/dlg/share-and-collaborate/SharePage.vue Removed getBaseUrl function; updated sharedViewUrl to use dashboardUrl directly; adjusted handling of activeView.
packages/nocodb/src/run/cloud.ts Introduced conditional logic for /dashboard routing based on NC_DASHBOARD_URL environment variable.

Possibly related PRs

  • Nc fix/miscellaneous #9447: This PR modifies the SharePage.vue component, which is closely related to the changes made in ShareBase.vue regarding the removal of the getBaseUrl function and the direct use of dashboardUrl.
  • Nc fix/misc #9678: This PR includes changes to ShareBase.vue, specifically simplifying the role toggling logic, which is relevant to the overall functionality of the shared base URL logic in the main PR.
  • Nc fix/misc UI changes #9829: This PR involves UI changes in components related to access control, which may indirectly relate to the shared base functionality and user interactions in ShareBase.vue.

Suggested reviewers

  • dstala
  • mertmit

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pranavxc pranavxc requested a review from mertmit December 9, 2024 09:57
@dosubot dosubot bot added the 🐛 Type: Bug Something is broken or incorrect unexpectedly. label Dec 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@mertmit mertmit merged commit 6f4d753 into develop Dec 9, 2024
7 of 44 checks passed
@mertmit mertmit deleted the nc-fix/dashboard-url branch December 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertmit mertmit mertmit approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. 🐛 Type: Bug Something is broken or incorrect unexpectedly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranavxc @mertmit
0