Nc fix/misc UI changes #9829
Merged
Nc fix/misc UI changes #9829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve modifications to the user interface of two Vue components: Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
packages/nc-gui/components/dashboard/settings/UIAcl.vue (1)
Line range hint
3-3: Consider type safety and documentation improvements.
- Consider using the
Roletype consistently instead of string literals:-const roles = ref<string[]>(['editor', 'commenter', 'viewer']) +const roles = ref<Role[]>(['editor', 'commenter', 'viewer'])
- Consider replacing the inline comment with proper JSDoc for the
saveUIAclfunction:+/** + * Saves the UI access control settings for tables + * Updates the visibility settings for modified tables and shows a success message + */ async function saveUIAcl() {Also applies to: 13-13, 89-89
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
packages/nc-gui/lang/en.jsonis excluded by!**/*.json
📒 Files selected for processing (2)
packages/nc-gui/components/dashboard/settings/DataSources.vue(1 hunks)packages/nc-gui/components/dashboard/settings/UIAcl.vue(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/nc-gui/components/dashboard/settings/DataSources.vue
| @@ -150,7 +150,7 @@ const columns = [ | |||
| <div class="w-full h-full flex flex-col"> | |||
| <NcTooltip class="mb-4 first-letter:capital font-bold max-w-100 truncate" show-on-truncate-only> | |||
| <template #title>{{ base.title }}</template> | |||
| <span> UI ACL : {{ base.title }} </span> | |||
| <span> {{ $t('labels.viewAccess') }} : {{ base.title }} </span> | |||
There was a problem hiding this comment.
💡 Codebase verification
Translation key needs to be added to other language files
The translation key labels.viewAccess is only present in the English locale file (en.json) but missing from all other language files. This could lead to missing translations for non-English users.
- Add the
labels.viewAccesstranslation key to all language files underpackages/nc-gui/lang/ - Currently only exists in:
packages/nc-gui/lang/en.json
🔗 Analysis chain
LGTM! Verify translation key exists.
The change improves i18n support by using the translation function for "View Access" text, which aligns with the terminology update across the UI.
Let's verify the translation key exists:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the 'labels.viewAccess' translation key exists in the localization files
# Search for the translation key in all locale files
rg -g '*.json' '"labels.viewAccess"' packages/nc-gui/lang/
Length of output: 60
Script:
#!/bin/bash
# Let's try a broader search to:
# 1. Find all JSON files in the lang directory
# 2. Look for any keys containing "viewAccess" (case insensitive)
# 3. Look for similar translations that might be using a different key
# List all JSON files in lang directory
echo "=== JSON files in lang directory ==="
fd -e json . packages/nc-gui/lang/
# Search for any keys containing viewAccess (case insensitive)
echo -e "\n=== Keys containing 'viewAccess' (case insensitive) ==="
rg -i "viewaccess" packages/nc-gui/lang/
# Search for similar translations that might use a different key
echo -e "\n=== Similar translations ==="
rg -i "\"view.*access\"" packages/nc-gui/lang/
Length of output: 1713
|
Uffizzi Preview |
632f200 to
3ad875e
Compare
dstala
approved these changes
Nov 16, 2024
This was referenced Nov 18, 2024
This was referenced Nov 29, 2024
Closed
This was referenced Dec 7, 2024
7 tasks
This was referenced Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Provide summary of changes with issue number if any.
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of