RELEASE 1.0.0 #26
Merged
RELEASE 1.0.0 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important! Template update for nf-core/tools v2.3.1
Add Docker URL
Fix linting, add sentence on usage
maxulysse
reviewed
Jun 12, 2023
maxulysse
reviewed
Jun 12, 2023
maxulysse
reviewed
Jun 12, 2023
maxulysse
reviewed
Jun 12, 2023
maxulysse
reviewed
Jun 12, 2023
maxulysse
reviewed
Jun 12, 2023
|
Tiny issues on the custom registry side, but mainly due to TEMPLATE not being up to date, we really need a tools release. |
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
adamrtalbot
reviewed
Jun 12, 2023
There was a problem hiding this comment.
As @maxulysse says, move the registry stuff out of the scopes. The profile scopes cause problems on Tower and any system that will set it's own configuration.
Fix issues for release
maxulysse
reviewed
Jun 12, 2023
Co-authored-by: Maxime U Garcia <maxime.garcia@seqera.io>
Co-authored-by: Christopher Mohr <contact.cmohr@gmail.com>
adamrtalbot
approved these changes
Jun 12, 2023
maxulysse
approved these changes
Jun 12, 2023
christopher-mohr
approved these changes
Jun 12, 2023
Co-authored-by: Christopher Mohr <contact.cmohr@gmail.com>
Co-authored-by: Christopher Mohr <contact.cmohr@gmail.com>
Final touches for release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).