8000 Dont exclude benchmarks from MANIFEST.in, need them for sample Balls by psobolewskiPhD · Pull Request #7189 · napari/napari · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Dont exclude benchmarks from MANIFEST.in, need them for sample Balls #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Dont exclude benchmarks from MANIFEST.in, need them for sample Balls #7189

wants to merge 2 commits into from

Conversation

psobolewskiPhD
Copy link
Member

References and relevant issues

Closes: #7185

Description

Balls were added to sample images in #6527 but the manifest wasn't updated to not exclude napari/benchmarks. This PR updates the manifest so benchmarks is in the wheel.

Hopefully in #7186 we can make CI fail with current main and then this PR will fix it.

@psobolewskiPhD psobolewskiPhD requested a review from a team as a code owner August 14, 2024 01:55
@psobolewskiPhD psobolewskiPhD added bugfix PR with bugfix maintenance PR with maintance changes, labels Aug 14, 2024
@psobolewskiPhD psobolewskiPhD added this to the 0.5.3 milestone Aug 14, 2024
@psobolewskiPhD psobolewskiPhD requested a review from Czaki August 14, 2024 01:56
@psobolewskiPhD
Copy link
Member Author

Or maybe it's better to just add this change to the other PR once we have tests failing? Your call!

@codecov Codecov
Copy link
codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (a8c822c) to head (0269ec2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7189      +/-   ##
==========================================
- Coverage   92.78%   92.68%   -0.10%     
==========================================
  Files         620      620              
  Lines       56779    56779              
==========================================
- Hits        52680    52626      -54     
- Misses       4099     4153      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki
Copy link
Collaborator
Czaki commented Aug 14, 2024

The #7186 reach state of properly failing tests.
It is good brick, but I think it may require add proper explanation. I try to add some basics here https://napari.zulipchat.com/#narrow/stream/212875-general/topic/Problem.20with.20installing.20from.20source.2Fbuild.20--wheel/near/462302314

But I will be happy if you get my commit into this PR and add explanation for future us to avoid problems in future.

@psobolewskiPhD
Copy link
Member Author

Maybe it's better the other way? put the fix in your PR to confirm CI will pass?

@Czaki Czaki mentioned this pull request Aug 14, 2024
Merged
@psobolewskiPhD
Copy link
Member Author

Closed in favor of #7186

jni pushed a commit that referenced this pull request Aug 15, 2024
@Czaki
Add napari.benchmarks.util to sdist and wheel to fix balls example …
a7e984b 
…data (#7186)

# References and relevant issues
closes #7185
closes #7189

# Description

Ensure that `napari.benchmarks.utils` is added to wheel and sdist,
because it is used in a sample menu item.
Fix testing workflow to fail if some additional file is missing in the
future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Czaki Czaki Awaiting requested review from Czaki

Assignees
No one assigned
Labels
bugfix PR with bugfix maintenance PR with maintance changes,
Projects
None yet
Milestone
0.5.3
Development

Successfully merging this pull request may close these issues.

Balls sample data are not working with napari installed from pip
2 participants
@psobolewskiPhD @Czaki
0