Add napari.benchmarks.util to sdist and wheel to fix balls example data
#7186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7186 +/- ##
==========================================
- Coverage 92.78% 92.68% -0.10%
==========================================
Files 620 620
Lines 56779 56779
==========================================
- Hits 52680 52625 -55
- Misses 4099 4154 +55 ☔ View full report in Codecov by Sentry. |
build both wheels and sdists
psobolewskiPhD
approved these changes
Aug 14, 2024
napari.benchamrsk.util to sdist and wheel
napari.benchamrsk.util to sdist and wheelnapari.benchamrsk.util to sdist and wheel to fix balls example data
napari.benchamrsk.util to sdist and wheel to fix balls example datanapari.benchamarsk.util to sdist and wheel to fix balls example data
|
@psobolewskiPhD could you check the title and description. |
|
@Czaki I tweaked the description. Good to go I think. |
napari.benchamarsk.util to sdist and wheel to fix balls example datanapari.benchmarks.util to sdist and wheel to fix balls example data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
closes #7185
closes #7189
Description
Ensure that
napari.benchmarks.utilsis added to wheel and sdist, because it is used in a sample menu item.Fix testing workflow to fail if some additional file is missing in the future.