8000 Re-enable lazy-loading tests by RomarQ · Pull Request #3312 · moonbeam-foundation/moonbeam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re-enable lazy-loading tests #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 13, 2025
Merged

Re-enable lazy-loading tests #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7e891a0
Revert "temporarily disable lazy-loading tests (#3219)"
RomarQ Jun 11, 2025
c04e838
fix(lazy-loading): fix condition in storage key iterator
RomarQ Jun 11, 2025
8d3ee74
fix
RomarQ Jun 11, 2025
f514161
improve code
RomarQ Jun 11, 2025
bd9e9a1
remove upgrade restriction signal
RomarQ Jun 11, 2025
43d946e
set enable_import_proof_recording to true
RomarQ Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,6 @@ jobs:
labels: bare-metal
permissions:
contents: read
if: false # Temporarily disabled
needs: ["set-tags", "build"]
strategy:
fail-fast: false
Expand Down
9 changes: 7 additions & 2 deletions node/service/src/lazy_loading/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,17 +1096,22 @@ impl<Block: BlockT + DeserializeOwned> sp_state_machine::Backend<HashingFor<Bloc
};

let maybe_next_key = if self.before_fork {
// Before the fork checkpoint, always fetch remotely
remote_fetch(self.block_hash)
} else {
// Try to get the next storage key from the local DB
let next_storage_key = self.db.read().next_storage_key(key);
match next_storage_key {
Ok(Some(key)) => Some(key),
Ok(Some(next_key)) => Some(next_key),
// If not found locally and key is not marked as removed, fetch remotely
_ if !self.removed_keys.read().contains_key(key) => {
remote_fetch(Some(self.fork_block))
}
// Otherwise, there's no next key
_ => None,
}
};
}
.filter(|next_key| next_key != key);

log::trace!(
target: super::LAZY_LOADING_LOG_TARGET,
Expand Down
9 changes: 1 addition & 8 deletions node/service/src/lazy_loading/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ use nimbus_primitives::NimbusId;
use parity_scale_codec::Encode;
use polkadot_primitives::{
AbridgedHostConfiguration, AsyncBackingParams, PersistedValidationData, Slot, UpgradeGoAhead,
UpgradeRestriction,
};
use sc_chain_spec::{get_extension, BuildGenesisBlock, GenesisBlockBuilder};
use sc_client_api::{Backend, BadBlocks, ExecutorProvider, ForkBlocks};
Expand Down Expand Up @@ -208,7 +207,7 @@ where
SyncMode::LightState { .. } | SyncMode::Warp { .. }
),
wasm_runtime_substitutes,
enable_import_proof_recording: false,
enable_import_proof_recording: true,
},
)?;

Expand Down Expand Up @@ -643,12 +642,6 @@ where
relay_chain::well_known_keys::CURRENT_SLOT.to_vec(),
Slot::from(u64::from(current_para_block)).encode(),
),
(
relay_chain::well_known_keys::upgrade_restriction_signal(
ParaId::new(parachain_id),
),
None::<UpgradeRestriction>.encode(),
),
];

4A04 let current_para_head = client_for_xcm
Expand Down
Loading
0