8000 Re-enable lazy-loading tests by RomarQ · Pull Request #3312 · moonbeam-foundation/moonbeam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Re-enable lazy-loading tests #3312

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

Re-enable lazy-loading tests #3312

merged 6 commits into from
Jun 13, 2025

Conversation

RomarQ
Copy link
Contributor
@RomarQ RomarQ commented Jun 11, 2025 •
edited
Loading
  • Fixes the lazy-loading storage iterator;
  • Removes upgrade_restriction_signal override from relay proof. (Needs to be done differently)
  • Reverts commit af375e8.

@RomarQ RomarQ requested review from a team as code owners June 11, 2025 12:39
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jun 11, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • agent-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RomarQ RomarQ marked this pull request as draft June 11, 2025 12:42
@RomarQ RomarQ self-assigned this Jun 11, 2025
@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes I4-tests 🎯 Tests need fixing, improving or augmenting. ci Continuous Integration pipeline D2-notlive PR doesn't change runtime code (so can't be audited) labels Jun 11, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 11, 2025 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2368 KB (no changes) ✅

Moonbeam runtime: 2356 KB (no changes) ✅

Moonriver runtime: 2352 KB (no changes) ✅

Compared to latest release (runtime-3701)

Moonbase runtime: 2368 KB (+312 KB compared to latest release) ⚠️

Moonbeam runtime: 2356 KB (+308 KB compared to latest release) ⚠️

Moonriver runtime: 2352 KB (+300 KB compared to latest release) ⚠️

@RomarQ RomarQ added the lazy-loading These changes affect the lazy loading feature label Jun 11, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 11, 2025 •
edited
Loading

Coverage Report

@@                   Coverage Diff                   @@
##           master   rq/fix-lazy-loading      +/-   ##
=======================================================
+ Coverage   75.38%                75.39%   +0.01%     
  Files         407                   407              
- Lines      101578                101574       -4     
=======================================================
  Hits        76573                 76573              
- Misses      25005                 25001       -4
Files Changed Coverage

Coverage generated Wed Jun 11 16:35:14 UTC 2025

@RomarQ RomarQ marked this pull request as ready for review June 11, 2025 15:59
@RomarQ RomarQ requested review from stiiifff and librelois June 11, 2025 16:47
@RomarQ RomarQ merged commit afc66a8 into master Jun 13, 2025
40 checks passed
@RomarQ RomarQ deleted the rq/fix-lazy-loading branch June 13, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@librelois librelois librelois approved these changes

@stiiifff stiiifff Awaiting requested review from stiiifff

Assignees

@RomarQ RomarQ

Labels
B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D2-notlive PR doesn't change runtime code (so can't be audited) I4-tests 🎯 Tests need fixing, improving or augmenting. lazy-loading These changes affect the lazy loading feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomarQ @librelois
0