10000 Fix State Trie Migration Tests: Change Zombienet clients to latest release instead of local #2974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchMoonbase runtime: 2188 KB (no changes) ✅ Moonbeam runtime: 2148 KB (no changes) ✅ Moonriver runtime: 2148 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2188 KB (+228 KB compared to latest release) Moonbeam runtime: 2148 KB (+224 KB compared to latest release) Moonriver runtime: 2148 KB (+224 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/state-migration-fix-poc +/- ##
=================================================================
+ Coverage 79.31% 79.39% +0.08%
Files 298 298
+ Lines 87140 87489 +349
=================================================================
+ Hits 69114 69454 +340
+ Misses 18026 18035 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR builds on top of #2907 and changes the zombienet configuration by replacing the parachain clients to use the latest release instead of the branch built node. While seeming work-aroundish the main purpose of the tests are simulating a runtime upgrade and testing communication with the relay chains so it should be safe to perform them with the previous client version.
Zombie RPC tests which seem to be the intended way to test the client retain the branch built client as the one used for RPC nodes.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Running the branch built clients with
--execution wasmflag was tested but yielded no result. It seems like the issue is related to the usage of native/wasm runtimes during the update fromstate_version = 0to1, but at the moment it does not seem clear what exactly is causing it.Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?