8000 State Trie Migration v1 by TarekkMA · Pull Request #2907 · moonbeam-foundation/moonbeam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

State Trie Migration v1 #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 68 commits into from
Oct 1, 2024
Merged

State Trie Migration v1 #2907

merged 68 commits into from
Oct 1, 2024

Conversation

TarekkMA
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@TarekkMA TarekkMA changed the title WIP State Trie Migration v2 WIP State Trie Migration v1 Aug 20, 2024
@RomarQ
Copy link
Contributor
RomarQ commented Aug 22, 2024

Some considerations about state tree migration can be found here: https://forum.polkadot.network/t/state-trie-migration/852/

@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes labels Aug 23, 2024
RomarQ
RomarQ reviewed Aug 23, 2024
View reviewed changes
TarekkMA and others added 4 commits August 23, 2024 16:32
@TarekkMA @RomarQ
Update runtime/moonbase/src/lib.rs
41e4610 
Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com>
@TarekkMA
migrate code
6657db1
@TarekkMA
fix
ea9e4c3
@TarekkMA
add pre/post upgrades
691c7aa
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Aug 27, 2024 •
edited
Loading

Coverage Report

@@                     Coverage Diff                      @@
##           master   tarekkma/state_migration      +/-   ##
============================================================
+ Coverage   79.18%                     79.23%   +0.05%     
  Files         299                        299              
+ Lines       87226                      87602     +376     
============================================================
+ Hits        69065                      69405     +340     
+ Misses      18161                      18197      +36
Files Changed Coverage
/pallets/moonbeam-lazy-migrations/src/lib.rs 83.54% (-8.77%) 🔽
/pallets/moonbeam-lazy-migrations/src/tests.rs 99.55% (-0.45%) 🔽
/runtime/common/src/migrations.rs 72.33% (+0.13%) 🔼

Coverage generated Mon Sep 30 23:23:10 UTC 2024

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Aug 27, 2024 •
edited
Loading

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2188 KB (no changes) ✅

Moonbeam runtime: 2148 KB (no changes) ✅

Moonriver runtime: 2148 KB (no changes) ✅

Compared to latest release (runtime-3200)

Moonbase runtime: 2188 KB (+228 KB compared to latest release) ⚠️

Moonbeam runtime: 2148 KB (+224 KB compared to latest release) ⚠️

Moonriver runtime: 2148 KB (+224 KB compared to latest release) ⚠️

RomarQ
RomarQ reviewed Aug 28, 2024
View reviewed changes
librelois
librelois reviewed Aug 28, 2024
View reviewed changes
librelois