8000 Enhance textarea tv type by smg6511 · Pull Request #16553 · modxcms/revolution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enhance textarea tv type #16553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2024
Merged

Enhance textarea tv type #16553

merged 3 commits into from
Jun 27, 2024

Conversation

smg6511
Copy link
Collaborator
@smg6511 smg6511 commented Apr 3, 2024

What does it do?

Adds new input options to control input height.

Why is it needed?

Currently this input type is restricted to its default size of 140px.

How to test

  1. Rebuild the manager template (cd to _build/templates/default and run grunt build)
  2. Clear MODX caches
  3. Create a few textarea type TVs to test the three new options (height, auto grow, and resize)

Related issue(s)/PR(s)

Resolves #5512

@smg6511 smg6511 requested review from opengeek and Mark-H as code owners April 3, 2024 19:57
@smg6511 smg6511 added the requires build Grunt build is required for integration label Apr 3, 2024
@codecov Codecov
Copy link
codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 21.55%. Comparing base (56c42e6) to head (1512af8).

❗ Current head 1512af8 differs from pull request most recent head 15e309e

Please upload reports for the commit 15e309e to get more accurate results.

Files Patch % Lines
...mplateVar/Configs/mgr/inputproperties/textarea.php 0.00% 29 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.x   #16553      +/-   ##
============================================
- Coverage     21.60%   21.55%   -0.06%     
+ Complexity    10592    10577      -15     
============================================
  Files           561      561              
  Lines         32052    32003      -49     
============================================
- Hits           6926     6898      -28     
+ Misses        25126    25105      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mark-H Mark-H added this to the v3.1.0 milestone Apr 8, 2024
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Apr 11, 2024
@jaygilmore
Copy link
Member

@smg6511 This does seem to function and it's a nice add.

One note, however, upon creation, until you change the values set for the Grow or Resizable input options, Revo throws a warning about undefined keys but once you change the input values the first time, this resolves.

[2024-05-31 13:59:15] (ERROR @ core/src/Revolution/Processors/Element/TemplateVar/Configs/mgr/inputproperties/textarea.php : 19) PHP warning: Undefined array key "textareaGrow"
[2024-05-31 13:59:15] (ERROR @ core/src/Revolution/Processors/Element/TemplateVar/Configs/mgr/inputproperties/textarea.php : 20) PHP warning: Undefined array key "textareaResizable"

It shouldn't require changing of the values as many people may not want to or need to change the values.

@smg6511
Copy link
Collaborator Author
smg6511 commented May 31, 2024

@jaygilmore Ok, got that covered. Thanks for taking a look.

@jaygilmore jaygilmore self-requested a review June 13, 2024 15:38
jaygilmore
jaygilmore approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member
@jaygilmore jaygilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@rthrash rthrash requested a review from jaygilmore June 13, 2024 15:42
theboxer
theboxer approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member
@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@rthrash rthrash added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Jun 27, 2024
smg6511 and others added 3 commits June 27, 2024 14:24
@smg6511 @opengeek
Enhance textarea tv type
46f9e79 
Adds new input options to control input height
@smg6511 @opengeek
Fix warnings for unset params
d32dbf9 
Adds new utility function to evaluate boolean-type values, which ensures only set params are accessed; applies this function to the two vars in the textarea input opts config file that were throwing php warnings. Note that the new function will be applicable to other config files.
@opengeek
grunt build
15e309e
@opengeek opengeek merged commit 78d3a99 into modxcms:3.x Jun 27, 2024
6 checks passed
@smg6511 smg6511 deleted the 3.x-issue-5512 branch August 27 8000 , 2024 16:14
@halftrainedharry halftrainedharry mentioned this pull request May 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaygilmore jaygilmore jaygilmore approved these changes

@theboxer theboxer theboxer approved these changes

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

Assignees
No one assigned
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging. requires build Grunt build is required for integration
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

TV input type "textarea" not high enough
6 participants
@smg6511 @jaygilmore @theboxer @opengeek @rthrash @Mark-H
0