10000 TV input type "textarea" not high enough · Issue #5512 · modxcms/revolution · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TV input type "textarea" not high enough #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mindeffects opened this issue Aug 12, 2011 · 13 comments · Fixed by #16553
Closed

TV input type "textarea" not high enough #5512

mindeffects opened this issue Aug 12, 2011 · 13 comments · Fixed by #16553
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.

Comments

@mindeffects
Copy link
Contributor

mindeffects created Redmine issue ID 5512

TV input type "textarea" is not high enough. RTFM says "about 15 lines", I count only about 8 lines (Chromium 15.x and FF5).

I will also write a feature request for textareas with editable height. Don't want to mix bugs and features. ;-)
@OptimusCrime
Copy link
Contributor

I has shrunk to 7 lines in 2.3 actually.

However, I don't feel the need to have it any higher. You could mix it up by seperating the content to another resource and use the content field there.

@pixelchutes
Copy link
Contributor

Another option is to use an editor, like Ace, to render large RichText TV inputs. One advantage here is that each individual editor can then toggle into fullscreen mode, providing maximum screen real estate / visibility, when needed.

That said, I do wish that core textarea TVs were at least resizable. Even native textareas are resizable in the browser, it's unfortunate that it is not currently supported. At a minimum, support for auto-expansion based on the length of the field's content (like the introtext field) would be a helpful improvement.

@mindeffects
Copy link
Contributor Author

Why not have the height as a setting of the TV itself? Wanna big textarea, make it 20rem. Or a small one, make it 3rem. Pro choice!
I often have the feeling, that "creative freedom" is something that should be also valid for the manager – since we all are building user interfaces for our customers. And the manager is, as we all know, just a website on top of MODX API. ;-)

@rthrash
Copy link
Member
rthrash commented Jul 8, 2014

A setting in the TV would be quite cool, as would a standard "resizable in the browser" widget. Think you could tackle that one @pixelchutes ?

@mindeffects
Copy link
Contributor Author

Thanks, @rthrash! I would like to grab the chance to start a discussion on how "creative freedom" could be extendet to the "Resource Editing Userinterfaces" we build with the MODX Manager.
GitHub here might not be the best place for that but I wanted to give you just an appetizer and (maybe) start something here: move, resize and organize the inputs in a grid with the arrows.
modx ideas seite 1
The red stroke in the full-width field is just an accident. ;-)

@rthrash
Copy link
Member
rthrash commented Jul 9, 2014

Man I would love to see something like that Oliver! And something like how Crowdin handles translations for label customization, too, including the ability to move the silly default fields, also.

@rthrash
Copy link
Member
rthrash commented Jul 9, 2014

On that note, I think this definitely merits another issue and the discussion is fine here on Github.

@mindeffects
Copy link
Contributor Author

Done, @rthrash. Please invite your friends to #11661 for punch and pie. ;-)

@devlanda
Copy link
devlanda commented Jul 7, 2017

I am working on a fix for this issue.

@devlanda devlanda mentioned this issue Jul 7, 2017
Closed
@pyrographics
Copy link

Not sure if it would be related to this issue or not but is in same ballpark. If you uncheck "Rich Text" on a resources settings to change a rich text box to a plain text box, a rich text TV correctly turns into a standard textarea but the size is so tiny (one short row) you can't use it and it cannot be resized.

@OptimusCrime
Copy link
Contributor

Perhaps worth opening a new issue for this? It does not concern the rich text editor.

@ilyautkin
Copy link
Contributor

PR #13524 is closed and feature is not implemented yet.
Confirmed for MODX 2.7.0

@JoshuaLuckers
Copy link
Contributor

There is a grow property that can be set to true. If true the textarea will be the same height as its content.

@JoshuaLuckers JoshuaLuckers added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. state/accepting-pull-request labels Mar 9, 2019
@smg6511 smg6511 mentioned this issue Apr 3, 2024
Merged
opengeek added a commit that referenced this issue Jun 27, 2024
@smg6511 @opengeek
Enhance textarea tv type (#16553)
78d3a99 
### What does it do?
Adds new input options to control input height.

### Why is it needed?
Currently this input type is restricted to its default size of 140px.

### How to test

1. Rebuild the manager template (cd to `_build/templates/default` and
run `grunt build`)
2. Clear MODX caches
3. Create a few textarea type TVs to test the three new options (height,
auto grow, and resize)

### Related issue(s)/PR(s)
Resolves #5512

---------

Co-authored-by: Jason Coward <jason@opengeek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue in the code or project, which should be addressed. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance textarea tv type smg6511/revolution
9 participants
@rthrash @pyrographics @alroniks @pixelchutes @mindeffects @JoshuaLuckers @OptimusCrime @ilyautkin @devlanda
0