-
Notifications
You must be signed in to change notification settings - Fork 18.8k
integration: run build session tests on non-experimental #39554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
arf
|
13103dd
to
bb8771e
Compare
The session endpoint is no longer experimental since 01c9e70, so we don't need to start an experimental daemon. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
bb8771e
to
becd29c
Compare
Tests passed https://jenkins.dockerproject.org/job/Docker-PRs/54922/console
|
Experimental failing on known flaky's https://jenkins.dockerproject.org/job/Docker-PRs-experimental/46021/console
s390x also failing on known flaky's
|
Janky https://jenkins.dockerproject.org/job/Docker-PRs/54922/console haven't seen that one failing for a while; if was flaky once #24805, which got addressed by specifying a lower restart delay #25085
Daemon logs for that test:
|
Janky failure on https://jenkins.dockerproject.org/job/Docker-PRs/54926/console
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; this is actually good if it accidentally increases flakiness in swarm tests as we have more motivation to attack those.
Hm... Docker Hub making a whoopsie?
|
The session endpoint is no longer experimental since 01c9e70 (#37686), so we don't need to start an experimental daemon.