8000 remove experimental guard for buildkit by andrewhsu · Pull Request #37686 · moby/moby · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

remove experimental guard for buildkit #37686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2018
Merged

remove experimental guard for buildkit #37686

merged 2 commits into from
Aug 21, 2018

Conversation

andrewhsu
Copy link
Contributor

- What I did

Allow buildkit builds to run without experimental mode enabled. Buildkit can now be twiddled with a specific flag #37593

- How I did it

- How to verify it

- Description for the changelog

  • Bring buildkit builds out of experimental.

- A picture of a cute animal (not mandatory but encouraged)

🐈

@andrewhsu
remove experimental guard for buildkit
239047c 
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
thaJeztah
thaJeztah approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member
@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

twiddle-dee-twiddle-dom

AntaresS
AntaresS approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor
@AntaresS AntaresS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah mentioned this pull request Aug 21, 2018
Merged
tiborvass
tiborvass requested changes Aug 21, 2018
View reviewed changes
Copy link
Contributor
@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

experimentalProvider could be removed in a followup.

But since buildkit relies on /session endpoint, that would also need to graduate out of experimental (remove router.Experimental in api/router/session)

@andrewhsu
move /session api endpoint out of experimental
01c9e70 
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@codecov
Copy link
codecov bot commented Aug 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@3bd1e7b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37686   +/-   ##
=========================================
  Coverage          ?   36.04%           
=========================================
  Files             ?      609           
  Lines             ?    45041           
  Branches          ?        0           
=========================================
  Hits              ?    16235           
  Misses            ?    26575           
  Partials          ?     2231

@AntaresS
Copy link
Contributor

@tiborvass I think Andrew has updated the PR. Can we get this one in first to avoid conflicts?

tiborvass
tiborvass approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor
@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass tiborvass merged commit 9972a82 into moby:master Aug 21, 2018
@andrewhsu andrewhsu deleted the bk-no-ex branch August 22, 2018 00:53
@thaJeztah thaJeztah mentioned this pull request Jul 17, 2019
Merged
This was referenced Oct 2, 2019
Merged
Merged
Merged
@thaJeztah
Copy link
Member

Looks like I forgot to follow-up on this one to update the docs; so, with some delay: #40028

@thaJeztah thaJeztah mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@AntaresS AntaresS AntaresS approved these changes

Assignees
No one assigned
Labels
area/builder impact/changelog kind/experimental status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewhsu @AntaresS @thaJeztah @tiborvass @GordonTheTurtle
0