Dont send any adapter other than from source directory for netcoreapp #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Reverted changes which were clearing extension cache after each request complete as it was breaking LUT
- Sending adapter from source directory so that net46 adapter will not get used to run netcoreapp tests
codito
reviewed
Jun 17, 2017
| @@ -176,20 +176,25 @@ public void Abort() | |||
|
|
|||
| private void InitializeExtensions(IEnumerable<string> sources) | |||
| { | |||
| var sourceList = sources.ToList(); | |||
| var extensions = this.testHostManager.GetTestPlatformExtensions(sourceList, TestPluginCache.Instance.DefaultExtensionPaths).ToList(); | |||
| List<string> extensions = new List<string>(); | |||
codito
reviewed
Jun 17, 2017
| // Only send this if needed. | ||
| if (extensions.Count() > 0) | ||
| if (extensionsToInitialize.Count() > 0) |
codito
reviewed
Jun 17, 2017
| expectedResult.AddRange(TestPluginCache.Instance.DefaultExtensionPaths); | ||
|
|
||
| this.testDiscoveryManager.Initialize(); | ||
|
|
codito
approved these changes
Jun 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.