Clear extensions cache after discover/execution complete. #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Windows_NT / Release Build |
1 similar comment
|
@dotnet-bot test Windows_NT / Release Build |
codito
reviewed
Jun 13, 2017
| @@ -225,6 +226,7 @@ public void HandleDiscoveryComplete(long totalTests, IEnumerable<TestCase> lastC | |||
| } | |||
| finally | |||
| { | |||
| TestPluginCache.Instance.ClearExtentions(); | |||
There was a problem hiding this comment.
nit: API spelling is incorrect.
|
@dotnet-bot test this please |
codito
reviewed
Jun 15, 2017
| @@ -8,6 +8,7 @@ namespace Microsoft.VisualStudio.TestPlatform.Client.Discovery | |||
| using System.Linq; | |||
| using System.Threading; | |||
|
|
|||
| using Microsoft.VisualStudio.TestPlatform.Common.ExtensionFramework; | |||
There was a problem hiding this comment.
nit: is this used in the code? There is not new addition in the file.
codito
approved these changes
Jun 15, 2017
|
@dotnet-bot test this please |
|
@dotnet-bot test Windows_NT / Debug Build please |
Faizan2304
added a commit
to Faizan2304/vstest
that referenced
this pull request
Jun 15, 2017
) * Clear cache after discover/execution complete. * Sort usings * Fix for issue: 1) microsoft#632 2) microsoft#844 * nitpick: Spelling * Addressed PR comment * spelling correction * nitpick: function name * Removed unused usings (cherry picked from commit 0eef86b)
Faizan2304
added a commit
that referenced
this pull request
Jun 15, 2017
* Clear extensions cache after discover/execution complete. (#853) * Clear cache after discover/execution complete. * Sort usings * Fix for issue: 1) #632 2) #844 * nitpick: Spelling * Addressed PR comment * spelling correction * nitpick: function name * Removed unused usings (cherry picked from commit 0eef86b) * Add portable pdb support for net46. (#856) (cherry picked from commit c70c0c8) * Install shared farmework compatible with particular version of CLI (#857) (cherry picked from commit 322bf71)
Faizan2304
pushed a commit
to Faizan2304/vstest
that referenced
this pull request
Jun 17, 2017
…crosoft#853)" This reverts commit 0eef86b.
Faizan2304
pushed a commit
to Faizan2304/vstest
that referenced
this pull request
Jun 18, 2017
…crosoft#853)" This reverts commit 0eef86b. (cherry picked from commit a0eee76)
Faizan2304
added a commit
that referenced
this pull request
Jun 18, 2017
…#876) * Revert "Clear extensions cache after discover/execution complete. (#853)" This reverts commit 0eef86b. (cherry picked from commit a0eee76) * Don’t send any adapter other than source directory for netcoreapp (cherry picked from commit 4aaaca3) * Address PR comment (cherry picked from commit 8395c7e) * Add comment (cherry picked from commit 4dcb465)
Faizan2304
added a commit
that referenced
this pull request
Jun 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.