8000 Support for "preset" and "env" in task provider by elahehrashedi · Pull Request #2636 · microsoft/vscode-cmake-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support for "preset" and "env" in task provider #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Aug 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
0c70759
build and config preset working correctly
elahehrashedi Jul 5, 2022
8686892
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Jul 5, 2022
d75f277
remove comments
elahehrashedi Jul 5, 2022
3bb2e55
Merge branch 'elrashed/taskPreset' of https://github.com/microsoft/vs…
elahehrashedi Jul 5, 2022
11a50c0
remove checkNeedsReconfigure
elahehrashedi Jul 6, 2022
4b80c91
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Jul 6, 2022
10f4fac
changelog
elahehrashedi Jul 6, 2022
d075528
Merge branch 'elrashed/taskPreset' of https://github.com/microsoft/vs…
elahehrashedi Jul 6, 2022
97afb7a
reply to reviews
elahehrashedi Jul 7, 2022
3e09760
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Jul 8, 2022
eaf38b4
replace "config --preset"
elahehrashedi Jul 8, 2022
d236a58
add test - not complete
elahehrashedi Jul 11, 2022
9ec9c46
test --preset
elahehrashedi Jul 12, 2022
06b5bb8
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Jul 22, 2022
409feca
lint error
elahehrashedi Jul 28, 2022
96fe833
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Jul 28, 2022
579a537
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Aug 2, 2022
b3d6c13
temporary
elahehrashedi Aug 4, 2022
7aad078
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Aug 8, 2022
07d448e
Merge branch 'elrashed/taskPreset' of https://github.com/microsoft/vs…
elahehrashedi Aug 8, 2022
907104c
test config with settings
elahehrashedi Aug 8, 2022
bb7a1da
package.json changes
elahehrashedi Aug 8, 2022
1ae8016
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Aug 8, 2022
aa4905b
write logs in task terminal
elahehrashedi Aug 9, 2022
c97f088
modify clean-rebuild to use build task
elahehrashedi Aug 9, 2022
e7faa97
customize runCTest again
elahehrashedi Aug 9, 2022
132091a
make useCMakePresets compatible with task
elahehrashedi Aug 12, 2022
d24a625
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Aug 12, 2022
22b59c8
add consumer for test task
elahehrashedi Aug 15, 2022
7e44248
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Aug 15, 2022
edc55e4
add more errors when preset not found
elahehrashedi Aug 15, 2022
8065daf
ignore targets in tasks other than build and clean-rebuild
elahehrashedi Aug 15, 2022
be72f27
change the code to make folder
elahehrashedi Aug 15, 2022
b0ed883
change code to make folder
elahehrashedi Aug 15, 2022
1856d75
fix error with install return code
elahehrashedi Aug 15, 2022
6dcc924
add more log data
elahehrashedi Aug 15, 2022
0c3abc8
keep results of install&clean in the task terminal
elahehrashedi Aug 15, 2022
098a7cc
only bypass _needsReconfigure
elahehrashedi Aug 16, 2022
282e247
add active preset as default
elahehrashedi Aug 22, 2022
dd74ebd
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Aug 22, 2022
1c7720b
Merge branch 'elrashed/taskPreset' of https://github.com/microsoft/vs…
elahehrashedi Aug 22, 2022
c0cc706
reply to reviews
elahehrashedi Aug 22, 2022
3d98f9a
add new trigger and modify config
elahehrashedi Aug 23, 2022
e09b495
different task vs active config preset working fine
elahehrashedi Aug 23, 2022
ec58514
linter errors
elahehrashedi Aug 23, 2022
f07a2e5
update codeModel
elahehrashedi Aug 23, 2022
d569210
presets are working when defined explicitly
elahehrashedi Aug 24, 2022
647fce0
when there is no preset, we need to resolve the active preset name
elahehrashedi Aug 24, 2022
aafae87
Merge branch 'main' into elrashed/taskPreset
elahehrashedi Aug 25, 2022
3988891
Fix test break
bobbrow Aug 25, 2022
5602eb6
reply to reviews
elahehrashedi Aug 25, 2022
2616745
fix package.json
bobbrow Aug 25, 2022
f25eb93
restore spacing in package.json
bobbrow Aug 25, 2022
97742a7
call getGeneratorNameForTelemetry for presets
elahehrashedi Aug 26, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Improvements:
- Triggering reconfigure after changes are made to included files. [#2526](https://github.com/microsoft/vscode-cmake-tools/issues/2526) [@chausner](https://github.com/chausner)
- Support for presets version 4. [#2492](https://github.com/microsoft/vscode-cmake-tools/issues/2492) [@chausner](https://github.com/chausner)
- Add target name to terminal window name for launch. [#2613](https://github.com/microsoft/vscode-cmake-tools/issues/2613)
- Add support for "preset" and "env" in task provider. [#2636](https://github.com/microsoft/vscode-cmake-tools/issues/2636)
- Add Craig Scott's "Professional CMake" book to the list of resources in doc/faq.md for learning CMake. [#2679](https://github.com/microsoft/vscode-cmake-tools/pull/2679) [@david-fong](https://github.com/david-fong)

Bug Fixes:
Expand Down
57 changes: 33 additions & 24 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@
"properties": {
"label": {
"type": "string",
"description": "The name of the task"
"description": "%cmake-tools.taskDefinitions.properties.label.description%"
},
"command": {
"type": "string",
Expand All @@ -543,27 +543,36 @@
"clean",
"cleanRebuild"
],
"description": "CMake build command"
"description": "%cmake-tools.taskDefinitions.properties.command.description%"
},
"targets": {
"type": "array",
"items": {
"type": "string"
}
},
"description": "%cmake-tools.taskDefinitions.properties.targets.description%"
},
"preset": {
"type": "string",
"description": "%cmake-tools.taskDefinitions.properties.preset.description%"
},
"options": {
"type": "object",
"description": "Additional command options",
"description": &quo 10000 t;%cmake-tools.taskDefinitions.properties.options.description",
"properties": {
"cwd": {
"type": "string",
"description": "The current working directory of the executed program or script. If omitted Code's current workspace root is used."
"description": "%cmake-tools.taskDefinitions.properties.options.cwd.description%"
},
"environment": {
"type": "object",
"markdownDescription": "%cmake-tools.taskDefinitions.properties.options.environment.markdownDescription%"
}
}
},
"detail": {
"type": "string",
"description": "Additional details of the task"
"description": "%cmake-tools.taskDefinitions.properties.details.description%"
}
}
}
Expand Down Expand Up @@ -1234,24 +1243,24 @@
"description": "%cmake-tools.configuration.cmake.debugConfig.additionalSOLibSearchPath.description%"
},
"externalConsole": {
"type": "boolean",
"description": "%cmake-tools.configuration.cmake.debugConfig.externalConsole.description%"
"type": "boolean",
"description": "%cmake-tools.configuration.cmake.debugConfig.externalConsole.description%"
},
"console": {
"type": "string",
"enum": [
"internalConsole",
"integratedTerminal",
"externalTerminal",
"newExternalWindow"
],
"enumDescriptions": [
"%cmake-tools.configuration.cmake.debugConfig.console.internalConsole.description%",
"%cmake-tools.configuration.cmake.debugConfig.console.integratedTerminal.description%",
"%cmake-tools.configuration.cmake.debugConfig.console.externalTerminal.description%",
"%cmake-tools.configuration.cmake.debugConfig.console.newExternalWindow.description%"
],
"markdownDescription": "%cmake-tools.configuration.cmake.debugConfig.console.description%"
"type": "string",
"enum": [
"internalConsole",
"integratedTerminal",
"externalTerminal",
"newExternalWindow"
],
"enumDescriptions": [
"%cmake-tools.configuration.cmake.debugConfig.console.internalConsole.description%",
"%cmake-tools.configuration.cmake.debugConfig.console.integratedTerminal.description%",
"%cmake-tools.configuration.cmake.debugConfig.console.externalTerminal.description%",
"%cmake-tools.configuration.cmake.debugConfig.console.newExternalWindow.description%"
],
"markdownDescription": "%cmake-tools.configuration.cmake.debugConfig.console.description%"
},
"logging": {
"type": "object",
Expand Down Expand Up @@ -1912,7 +1921,7 @@
"%cmake-tools.configuration.cmake.revealLog.always.description%",
"%cmake-tools.configuration.cmake.revealLog.never.description%"
],
"description":"%cmake-tools.configuration.cmake.revealLog.description%"
"description": "%cmake-tools.configuration.cmake.revealLog.description%"
},
"cmake.exportCompileCommandsFile": {
"type": "boolean",
Expand Down Expand Up @@ -2141,4 +2150,4 @@
"extensionPack": [
"twxs.cmake"
]
}
}
8 changes: 8 additions & 0 deletions package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,14 @@
"cmake-tools.configuration.cmake.allowCommentsInPresetsFile.description": "Allow the use of JSON extensions such as comments in CMakePresets.json. Please note that your CMakePresets.json file may be considered invalid by other IDEs or on the command line if you use non-standard JSON.",
"cmake-tools.configuration.cmake.ignoreCMakeListsMissing.description": { "message": "If `true`, the extension will not ask the user to select a CMakeLists.txt file for configuration when one is found in the workspace but not in the root folder.", "comment": [ "Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered." ] },
"cmake-tools.configuration.cmake.launchBehavior.description": "Controls what happens with the launch terminal when you launch a target.",
"cmake-tools.taskDefinitions.properties.label.description": "The name of the task",
"cmake-tools.taskDefinitions.properties.command.description": "CMake command",
"cmake-tools.taskDefinitions.properties.targets.description": "CMake build targets",
"cmake-tools.taskDefinitions.properties.preset.description": "CMake preset name. This is a configuration, build or test preset, based on the CMake command",
"cmake-tools.taskDefinitions.properties.options.description": "Additional command options",
"cmake-tools.taskDefinitions.properties.options.cwd.description": "The current working directory of the executed program or script. If omitted Code's current workspace root is used.",
"cmake-tools.taskDefinitions.properties.options.environment.markdownDescription": { "message": "Environment variables in the format of \"name\": \"value\".", "comment": [ "\"name\": \"value\" should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation should not be altered." ] },
"cmake-tools.taskDefinitions.properties.details.description": "Additional details of the task",
"cmake-tools.configuration.cmake.launchBehavior.reuseTerminal.markdownDescriptions": "The launch terminal instance is reused and the target will launch as soon as the terminal is idle.",
"cmake-tools.configuration.cmake.launchBehavior.breakAndReuseTerminal.markdownDescriptions": { "message": "The launch terminal instance is reused and a `break` command is sent to terminate any active foreground process before launching the target.", "comment": [ "Markdown text between `` should not be translated or localized (they represent literal text) and the capitalization, spacing, and punctuation (including the ``) should not be altered." ] },
"cmake-tools.configuration.cmake.launchBehavior.newTerminal.markdownDescriptions": "A new terminal instance is created and the target is launched in it. Existing terminals are not automatically cleaned up."
Expand Down
Loading
0