8000 Support for "preset" and "env" in task provider by elahehrashedi · Pull Request #2636 · microsoft/vscode-cmake-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support for "preset" and "env" in task provider #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Aug 26, 2022
Merged

Support for "preset" and "env" in task provider #2636

merged 54 commits into from
Aug 26, 2022

Conversation

elahehrashedi
Copy link
Contributor
@elahehrashedi elahehrashedi commented Jul 5, 2022 •
edited
Loading

feature-request: #2553
bug fix: CMake install does not run in terminal as a task

sample:

{
	"version": "2.0.0",
	"tasks": [
		{
			"type": "cmake",
			"label": "1CMake build with presets",
			"command": "build",
			"targets": [
				"main"
			],
			"preset": "${command:cmake.activeBuildPresetName}",
			"options": {
				"cwd": "${command:cmake.buildDirectory}"
			},
			"dependsOn": [
				"1CMake configure with presets"
			],
			"detail": "CMake build with presets"
		},
		{
			"type": "cmake",
			"label": "1CMake configure with presets",
			"command": "configure",
			"preset": "${command:cmake.activeConfigurePresetName}",
			"options": {
				"cwd": "${workspaceFolder}/"
			},
			"detail": "CMake configure with presets"
		},
		{
			"type": "cmake",
			"label": "2CMake build without presets",
			"command": "build",
			"targets": [
				"main"
			],
			"options": {
				"cwd": "${command:cmake.buildDirectory}"
			},
			"group": "build",
			"problemMatcher": [],
			"dependsOn": [
				"2CMake configure without presets"
			],
			"detail": "CMake build without presets"
		},
		{
			"type": "cmake",
			"label": "2CMake configure without presets",
			"command": "configure",
			"options": {
				"cwd": "${command:cmake.buildDirectory}"
			},
			"problemMatcher": [],
			"detail": "CMake configure without presets"
		}
	]
}

@elahehrashedi elahehrashedi requested a review from a team July 5, 2022 23:33
This was referenced Jul 5, 2022
Closed
Open
@elahehrashedi elahehrashedi requested a review from bobbrow July 6, 2022 17:28
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow reviewed Jul 7, 2022
View reviewed changes
bobbrow
bobbrow requested changes Jul 7, 2022
View reviewed changes
Copy link
Member
@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@elahehrashedi elahehrashedi requested a review from bobbrow July 8, 2022 00:01
@bobbrow bobbrow linked an issue Jul 8, 2022 that may be closed by this pull request
Passing environment variable to "cmake" tasks #2553
Closed
@bobbrow bobbrow added this to the 1.12 milestone Jul 8, 2022
@elahehrashedi elahehrashedi requested a review from bobbrow August 23, 2022 22:29
bobbrow
bobbrow reviewed Aug 23, 2022
View reviewed changes
bobbrow
bobbrow reviewed Aug 24, 2022
View reviewed changes 8000
@elahehrashedi elahehrashedi requested a review from bobbrow August 24, 2022 02:49
bobbrow
bobbrow reviewed Aug 25, 2022
View reviewed changes
@elahehrashedi elahehrashedi requested a review from bobbrow August 25, 2022 20:58
bobbrow
bobbrow requested changes Aug 25, 2022
View reviewed changes
@elahehrashedi elahehrashedi requested a review from bobbrow August 26, 2022 03:16
@bobbrow bobbrow merged commit aa00c93 into main Aug 26, 2022
@bobbrow bobbrow deleted the elrashed/taskPreset branch August 26, 2022 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow approved these changes

@Colengms Colengms Awaiting requested review from Colengms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12
Development

Successfully merging this pull request may close these issues.

CMake install does not run in terminal as a task Passing environment variable to "cmake" tasks
2 participants
@elahehrashedi @bobbrow
0