8000 ENG-268 Enable ingestion on data pipeline by leite08 · Pull Request #3913 · metriport/metriport · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ENG-268 Enable ingestion on data pipeline #3913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

ENG-268 Enable ingestion on data pipeline #3913

merged 1 commit into from
May 29, 2025

Conversation

leite08
Copy link
Member
@leite08 leite08 commented May 29, 2025 •
edited
Loading

Dependencies

Description

Enable ingestion on data pipeline.

Testing

  • Local
    • none
  • Staging
    • Successful ingestion when consolidated is recreated
  • Sandbox
    • none
  • Production
    • none

Release Plan

  • RELEASE upstream
  • Merge this

Summary by CodeRabbit

  • Bug Fixes
    • Restored the ability to process and ingest consolidated patient data into the search engine, ensuring improved data availability and search functionality.

@leite08
refactor(api): enable ingest on data-pipeline
50db0b8 
Ref eng-268

Signed-off-by: Rafael Leite <2132564+leite08@users.noreply.github.com>
@linear Linear
Copy link
linear bot commented May 29, 2025

ENG-268 [BE] Global Search by keyword - endpoint

@leite08 leite08 marked this pull request as ready for review May 29, 2025 17:41
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 29, 2025 •
edited
Loading

Walkthrough

The code re-enables the ingestion of consolidated patient data into a search engine by uncommenting relevant import and function call lines. This restores asynchronous ingestion with error handling in the recreateConsolidated function. No changes were made to function signatures or overall control flow.

Changes

File(s) Change Summary
packages/api/src/command/medical/patient/consolidated-recreate.ts Uncommented import and ingestion logic; restored async ingestion call.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant recreateConsolidated
    participant makeIngestConsolidated
    participant ingestConsolidatedIntoSearchEngine
    participant processAsyncError

    Caller->>recreateConsolidated: call with patient info
    recreateConsolidated->>makeIngestConsolidated: create ingestor
    recreateConsolidated->>ingestConsolidatedIntoSearchEngine: ingest data (async)
    ingestConsolidatedIntoSearchEngine-->>recreateConsolidated: result/error
    recreateConsolidated->>processAsyncError: handle error if any
    recreateConsolidated-->>Caller: return
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/punycode/-/punycode-2.3.1.tgz failed, reason: C00C2BB05F7F0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-29T17_42_19_841Z-debug-0.log

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2934c3 and 50db0b8.

📒 Files selected for processing (1)
  • packages/api/src/command/medical/patient/consolidated-recreate.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.ts`: - Use the Onion Pattern to organize a package's code in layers - Try to use immutable code and avoid sharing state across different functions, objects, and systems - Try...

**/*.ts: - Use the Onion Pattern to organize a package's code in layers

  • Try to use immutable code and avoid sharing state across different functions, objects, and systems
  • Try to build code that's idempotent whenever possible
  • Prefer functional programming style functions: small, deterministic, 1 input, 1 output
  • Minimize coupling / dependencies
  • Avoid modifying objects received as parameter
  • Only add comments to code to explain why something was done, not how it works
  • Naming
    • classes, enums: PascalCase
    • constants, variables, functions: camelCase
    • file names: kebab-case
    • table and column names: snake_case
    • Use meaningful names, so whoever is reading the code understands what it means
    • Don’t use negative names, like notEnabled, prefer isDisabled
    • For numeric values, if the type doesn’t convey the unit, add the unit to the name
  • Typescript
    • Use types
    • Prefer const instead of let
    • Avoid any and casting from any to other types
    • Type predicates: only applicable to narrow down the type, not to force a complete type conversion
    • Prefer deconstructing parameters for functions instead of multiple parameters that might be of
      the same type
    • Don’t use null inside the app, only on code interacting with external interfaces/services,
      like DB and HTTP; convert to undefined before sending inwards into the code
    • Use async/await instead of .then()
    • Use the strict equality operator ===, don’t use abstract equality operator ==
    • When calling a Promise-returning function asynchronously (i.e., not awaiting), use .catch() to
      handle errors (see processAsyncError and emptyFunction depending on the case)
    • Date and Time
      • Always use buildDayjs() to create dayjs instances
      • Prefer dayjs.duration(...) to create duration consts and keep them as duration
  • Prefer Nullish Coalesce (??) than the OR operator (||) to provide a default value
  • Avoid creating arrow functions
  • Use truthy syntax instead of in - i.e., if (data.link) not if ('link' in data)
  • Error handling
    • Pass the original error as the new one’s cause so the stack trace is persisted
    • Error messages should have a static message - add dynamic data to MetriportError's additionalInfo prop
    • Avoid sending multiple events to Sentry for a single error
  • Global constants and variables
    • Move literals to constants declared after imports when possible (avoid magic numbers)
    • Avoid shared, global objects
  • Avoid using console.log and console.error in packages other than ut 8000 ils, infra and shared,
    and try to use out().log instead
  • Avoid multi-line logs
    • don't send objects as a second parameter to console.log() or out().log()
    • don't create multi-line strings when using JSON.stringify()
  • Use eslint to enforce code style
  • Use prettier to format code
  • max column length is 100 chars
  • multi-line comments use /** */
  • scripts: top-level comments go after the import
  • packages/api/src/command/medical/patient/consolidated-recreate.ts
🧠 Learnings (1)
packages/api/src/command/medical/patient/consolidated-recreate.ts (1) 
Learnt from: leite08
PR: metriport/metriport#3814
File: packages/api/src/routes/internal/medical/patient-consolidated.ts:141-174
Timestamp: 2025-05-20T21:26:26.804Z
Learning: The functionality introduced in packages/api/src/routes/internal/medical/patient-consolidated.ts is planned to be refactored in downstream PR #3857, including improvements to error handling and validation.
🧬 Code Graph Analysis (1)
packages/api/src/command/medical/patient/consolidated-recreate.ts (2)
packages/core/src/command/consolidated/search/fhir-resource/ingest-consolidated-factory.ts (1)
  • makeIngestConsolidated (6-11)
packages/api/src/command/medical/patient/__tests__/store-query-cmd.ts (1)
  • patient (15-15)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: check-pr / lint-build-test
🔇 Additional comments (2)
packages/api/src/command/medical/patient/consolidated-recreate.ts (2)

5-5: LGTM! Import properly restored.

The import of makeIngestConsolidated has been correctly uncommented to re-enable the ingestion functionality. The factory function will provide the appropriate ingestion implementation based on the environment.

59-65: LGTM! Ingestion functionality properly re-enabled.

The ingestion call has been correctly restored with:

  • Proper use of the factory pattern to create the ingestor instance
  • Appropriate async error handling using .catch(processAsyncError(...))
  • Correct timing within the function flow (after consolidated data recreation)
  • Follows coding guidelines by using .catch() for non-awaited promise operations

The implementation ensures that ingestion failures won't disrupt the main consolidated recreation flow while still providing proper error tracking.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

This was referenced May 29, 2025
Merged
Draft
Base automatically changed from eng-268-index-all-consolidated-into-open-search to develop May 29, 2025 17:53
@leite08 leite08 mentioned this pull request May 29, 2025
Merged
3 tasks
@leite08 leite08 changed the title EENG-268 Enable ingestion on data pipeline ENG-268 Enable ingestion on data pipeline May 29, 2025
@leite08 leite08 added this pull request to the merge queue May 29, 2025
Merged via the queue into develop with commit f63f92b May 29, 2025
12 checks passed
@leite08 leite08 deleted the eng-268-index-all-consolidated-into-open-search_2 branch May 29, 2025 21:29
This was referenced May 29, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jun 1, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamilGaripov RamilGaripov RamilGaripov approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@thomasyopes thomasyopes Awaiting requested review from thomasyopes thomasyopes is a code owner

@lucasdellabella lucasdellabella Awaiting requested review from lucasdellabella lucasdellabella is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leite08 @RamilGaripov
0