8000 ENG-226 Set max ECS task count on restart + Update autoscale threshold by leite08 · Pull Request #3765 · metriport/metriport · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ENG-226 Set max ECS task count on restart + Update autoscale threshold #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

ENG-226 Set max ECS task count on restart + Update autoscale threshold #3765

merged 2 commits into from
May 1, 2025

Conversation

leite08
Copy link
Member
@leite08 leite08 commented May 1, 2025 •
edited
Loading

Dependencies

none

Description

Set max ECS task count when restarting API to 160% - context

Update autoscale threshold:

  • from 60 to 10 CPU
  • from 80 to 20 MEM

Testing

  • Local
    • none
  • Staging
    • none
  • Sandbox
    • none
  • Production
    • ECS Service update to 160% max and 70% min task count
    • Auto-scale thresholds updated

Release Plan

  • Merge this

Summary by CodeRabbit

  • Chores
    • Updated deployment health thresholds for the production environment to optimize service update behavior.

@leite08
refactor: max 160% ECS task count when restarting API
321d73d 
Ref eng-226

Signed-off-by: Rafael Leite <2132564+leite08@users.noreply.github.com>
@linear Linear
Copy link
linear bot commented May 1, 2025

ENG-226 Improve the performance of our CICD (faster releases)

@leite08 leite08 marked this pull request as ready for review May 1, 2025 00:36
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 1, 2025 •
edited
Loading

Error: Could not generate a valid Mermaid diagram after multiple attempts.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Lite

📥 Commits

Reviewing files that changed from the base of the PR and between 321d73d and e86dda4.

📒 Files selected for processing (1)
  • packages/infra/lib/api-stack/api-service.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/infra/lib/api-stack/api-service.ts
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leite08
refactor: auto scale at 10 cpu and 20 mem
e86dda4 
Ref eng-226

Signed-off-by: Rafael Leite <2132564+leite08@users.noreply.github.com>
@leite08 leite08 changed the title ENG-226 Set max ECS task count when restarting API ENG-226 Set max ECS task count on restart + Update autoscale threshold May 1, 2025
@leite08 leite08 requested a review from thomasyopes May 1, 2025 00:56
@leite08 leite08 added this pull request to the merge queue May 1, 2025
@leite08 leite08 removed this pull request from the merge queue due to a manual request May 1, 2025
@leite08 leite08 added this pull request to the merge queue May 1, 2025
Merged via the queue into develop with commit a08d0cb May 1, 2025
17 checks passed
@leite08 leite08 deleted the eng-226-adj-max-health-ecs-tasks branch May 1, 2025 12:19
@leite08 leite08 mentioned this pull request May 1, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasyopes thomasyopes thomasyopes approved these changes

@Goncharo Goncharo Awaiting requested review from Goncharo Goncharo is a code owner

@Orta21 Orta21 Awaiting requested review from Orta21 Orta21 is a code owner

@RamilGaripov RamilGaripov Awaiting requested review from RamilGaripov RamilGaripov is a code owner

@lucasdellabella lucasdellabella Awaiting requested review from lucasdellabella lucasdellabella is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leite08 @thomasyopes
0