8000 Removing non core profiles from the Default profiles to avoid corruption by SimonDarksideJ · Pull Request #118 · XRTK/com.xrtk.sdk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 11, 2024. It is now read-only.

Removing non core profiles from the Default profiles to avoid corruption #118

Closed
wants to merge 7 commits into from
Closed

Removing non core profiles from the Default profiles to avoid corruption #118

wants to merge 7 commits into from

Conversation

SimonDarksideJ
Copy link
Contributor
@SimonDarksideJ SimonDarksideJ commented Jan 5, 2020 •
edited
Loading

Overview

Corresponding SDK PR to remove profiles that are broken as they are not part of core. These should be added by the platform when imported

This is centered around the work in the following core PR which will move profiles for non-core configuration to their respective package, e.g. Oculus, Lumin, WMR
XRTK/com.xrtk.core#433

Those packages will prompt the user to add the configuration if not configured for use.

@SimonDarksideJ SimonDarksideJ self-assigned this Jan 5, 2020
@SimonDarksideJ SimonDarksideJ requested a review from FejZa January 5, 2020 15:02
@StephenHodgson
Copy link
Contributor

I'm not sure I agree with this change, as the default profiles are all included in the sdk, not the core.

Can you explain this problem a bit more?

@SimonDarksideJ
Copy link
Contributor Author

In short, If you add the SDK to your project without dependant projects loaded (Oculus / Lumin / WMR) then any Core profile using those dependencies becomes corrupted.
In 2019.1 and below, this corruption only happened when you hit configure, so you could load all the projects before use. In 2019.2+ with the new Asset Database however, this is done on import.

In short, you are left with a situation with invalid configuration.

The better answer, is for each platform to add it's own defaults when loaded to avoid complication

@StephenHodgson
Copy link
Contributor

So there's other PRs that are blocking this one that implement this autoloading?

@SimonDarksideJ
Copy link
Contributor Author

The Profile validation PR's will ultimately load the configuration on request, moving the default profiles for those systems into their respective packages.
XRTK/com.xrtk.core#433

@StephenHodgson
Copy link
Contributor

Please be sure to reference any blocking or associated PRs in the overview above.

@StephenHodgson StephenHodgson reopened this Jan 9, 2020
@StephenHodgson
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@StephenHodgson StephenHodgson reopened this Apr 3, 2020
@StephenHodgson StephenHodgson mentioned this pull request Apr 5, 2020
Closed
@SimonDarksideJ
Copy link
Contributor Author

Deleting this PR until the mappings work (#150) is done and re-evaluating

@StephenHodgson StephenHodgson deleted the ControllerMappingValidation branch May 13, 2020 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenHodgson StephenHodgson Awaiting requested review from StephenHodgson

@FejZa FejZa Awaiting requested review from FejZa

Assignees

@SimonDarksideJ SimonDarksideJ

Labels
Blocked Breaking Change Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonDarksideJ @StephenHodgson
0