This repository was archived by the owner on Aug 11, 2024. It is now read-only.
Controller mapping detection #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactoring the Controller Mapping query to make it use an extension so the same logic can be used throughout the framework.
…on exists, both profiles and mappings
XRTK-Core/Packages/com.xrtk.core/Utilities/Editor/PathFinder.cs
Outdated
Show resolved
Hide resolved
XRTK-Core/Packages/com.xrtk.core/Utilities/ValidateConfiguration.cs
Outdated
Show resolved
Hide resolved
…XRTK-Core into ControllerMappingDetection
|
Your SDK submodule is pointing to a branch that might have been deleted. Try updating it to the latest development branch. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ControllerMappingDetection
…XRTK-Core into ControllerMappingDetection
…XRTK-Core into ControllerMappingDetection
XRTK-Core/Packages/com.xrtk.core/Utilities/ValidateConfiguration.cs
Outdated
Show resolved
Hide resolved
|
After some serious review, I simply removed the editor namespace. Moving it to the editor fold caused a whole heap of issues and cross dependency issues. |
StephenHodgson
approved these changes
Jan 28, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Feb 8, 2020
* Initial check-in. Refactoring the Controller Mapping query to make it use an extension so the same logic can be used throughout the framework. * Editor folder clean up, removed junk class and added license info to IconEditor class * Reverting PathFinder deletion and added license * Added utility to check and validate if Controller Mapping configuration exists, both profiles and mappings * Removed successful message which was only for testing * Fixed License * Fixed License * Finalised testing, ready for review * Resolved EditorPrefs warning and fixed script icon * Removed .Editor namespace. Co-authored-by: Stephen Hodgson <StephenHodgson@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is close
2EF5
d.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
First part of resolving #431, to detect and check if a platform has any profiles configured.
Will still required each platform to have an editor script to check configuration on load, which I'm testing.
Next step is to also generate and add configuration automatically.
Target of the change:
Is this enhancement for: