8000 Update geth to v.15.5 in order to support decoding of SetCodeTx by ParthDesai · Pull Request #1426 · Snowfork/snowbridge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update geth to v.15.5 in order to support decoding of SetCodeTx #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHu 8000 b”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 28, 2025
Merged

Update geth to v.15.5 in order to support decoding of SetCodeTx #1426

merged 4 commits into from
Mar 28, 2025

Conversation

ParthDesai
Copy link
Contributor

Description

This PR updates geth used by relayer to v1.15.5 reason being new tx type called SetCodeTx was introduced in EIP 7702 as part of pectra upgrade and its currently enabled on sepolia test network.

Due to this, the relayer with older version of geth gets stuck trying to decode a receipt and cannot make progress. So, we need to update geth so relayer is able to decode it correctly.

@vgeddes
Copy link
Collaborator
vgeddes commented Mar 27, 2025

@claravanstaden @yrong Can you review please?

yrong
yrong approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor
@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume it won't impact the relayer, but I'm still fine with merging this change.

claravanstaden
claravanstaden reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor
@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthDesai

go: module github.com/ethereum/go-ethereum@v1.15.5 requires go >= 1.23.0 (running go 1.22.5)

May you please update the Go version:

go 1.23

toolchain go1.23.0

If you can it would be good to also update in our CI:

Thank you!

@ParthDesai
Copy link
Contributor Author

I would assume it won't impact the relayer, but I'm still fine with merging this change.

We actually encountered this issue in sepolia network which prompted us to investigate. Due to below error relayer was constantly restarting and unable to make further progress.

{"@timestamp":"2025-03-24T13:38:48.905434478Z","level":"info","message":"relayer waiting period","waitingPeriod":0}
{"@timestamp":"2025-03-24T13:38:49.255376974Z","blockHash":"0x371876da86cb9884362b58963bf192f94c6e13c33478a877095af865c425a352","blockNumber":7939753,"error":"get block: transaction type not supported","level":"error","message":"Failed to get receipt trie for event","txHash":"0x3df2e04a82ff0106bb0d8a94d9fb728a43aeda45b52a62cfecd2b91e97011795"}
{"@timestamp":"2025-03-24T13:38:49.255419291Z","error":"submit event: submit inbound message: make outgoing message: get block: transaction type not supported","level":"fatal","message":"Unhandled error"}

@ParthDesai
Copy link
Contributor Author

@ParthDesai

go: module github.com/ethereum/go-ethereum@v1.15.5 requires go >= 1.23.0 (running go 1.22.5)

May you please update the Go version:

go 1.23

toolchain go1.23.0

If you can it would be good to also update in our CI:

* https://github.com/Snowfork/snowbridge/blob/main/.github/workflows/relayer.yml#L25

* https://github.com/Snowfork/snowbridge/blob/main/.github/workflows/release-relayer.yml#L32

Thank you!

Done.

@claravanstaden
Copy link
Contributor

Looks like a test is failing due to a geth interface change:

# github.com/snowfork/snowbridge/relayer/chain/ethereum_test [github.com/snowfork/snowbridge/relayer/chain/ethereum.test]


chain/ethereum/header_cache_state_test.go:58:72: too many arguments in call to gethTypes.NewBlockWithHeader(&header).WithBody


	have ([]*"github.com/ethereum/go-ethereum/core/types".Transaction, []*"github.com/ethereum/go-ethereum/core/types".Header)


	want ("github.com/ethereum/go-ethereum/core/types".Body)

@ParthDesai
Copy link
Contributor Author

Looks like a test is failing due to a geth interface change:

# github.com/snowfork/snowbridge/relayer/chain/ethereum_test [github.com/snowfork/snowbridge/relayer/chain/ethereum.test]


chain/ethereum/header_cache_state_test.go:58:72: too many arguments in call to gethTypes.NewBlockWithHeader(&header).WithBody


	have ([]*"github.com/ethereum/go-ethereum/core/types".Transaction, []*"github.com/ethereum/go-ethereum/core/types".Header)


	want ("github.com/ethereum/go-ethereum/core/types".Body)

Fixed it. Tests are passing now.

@claravanstaden claravanstaden merged commit 7c1be2c into Snowfork:main Mar 28, 2025
1 of 2 checks passed
yrong added a commit that referenced this pull request Mar 31, 2025
@yrong @alistair-singh
@claravanstaden @ParthDesai
Merge updates from V1 (#1429)
1bcc917 
* Add support for ether (#1409)

* Upgrade gateway on Sepolia for westend (#1407)

* Log gateway codehash

* Upgrade Gateway on Westend-Sepolia

* Update indexer endpoint & Cleanup (#1411)

* Ban lido token (#1412)

* Fix hardcoded url (#1414)

* Register Polkadot Native Assets in Control Tool (#1405)

* added function to register tokens

* fmt

* fix build errors

* clean up

* more assets

* fix message

* more tokens

* Update control/preimage/src/commands.rs

---------

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

* Force rebuild (#1418)

* Format codes (#1416)

* remove equilibrium and its stable coin (#1421)

* Hot fix (#1424)

* Update Bifrost RPC endpoint

* Update package

* Update geth to v.15.5 in order to support decoding of SetCodeTx (#1426)

* update geth to v.15.5 in order to support decoding of SetCodeTx

* update go to 1.23.0

* update Go version in CI

* fix breaking test

* Cleanup

---------

Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Parth <desaiparth08@gmail.com>
yrong added a commit that referenced this pull request Apr 2, 2025
@vgeddes @claravanstaden
@yrong @alistair-singh @ParthDesai
V2 (#1371)
59f05c6 
* Contracts V2 (#1300)

* Ethereum Relayer V2 (#1341)

* v2 initial commit

* latest changes

* Flesh out dispatch logic for inbound messages

* Add reward address

* make code compile

* Split initializer impl into a library to reduce contract size

* Major refactor

* Update tests

* add scripts back

* Update scripts

* Finish outbound messaging

* Implement token registration for V2

* Make functions payable

* improve docs

* comments

* review feedback

* cleanups

* Add initial tests for V2

* Make `rewardAddress` an indexed event parameter

* Clean up interfaces

* Make WETH address configurable

* Autowrap ether

* auto-unwrap ether

* Add view keyword

* off-chain part

* off-chain changes

* improve

* improve

* allow unlocking native ether

* improve token registration flows

* improve docs

* improve

* improve

* nit

* Update contracts/src/v1/Calls.sol

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

* Apply suggestions from code review

Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>

* Fix unlock WETH

* Suppress Error (6243): The "tload" instruction

* Merge recent changes

* add foundry setting

* relayer progress

* fixes

* adds xcm

* register token v2

* clean up register token smoketest

* fmt

* merge damage

* fix tests

* send token and relayer fixes

* relayer cleanup and transact

* send token to penpal smoke test

* syntax error

* adds penpal test to ci

* merge damage fixes

---------

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>
Co-authored-by: ron <yrong1997@gmail.com>
Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>

* Parachain Relayer V2 (#1321)

* v2 initial commit

* latest changes

* Flesh out dispatch logic for inbound messages

* Add reward address

* make code compile

* Split initializer impl into a library to reduce contract size

* Major refactor

* Update tests

* add scripts back

* Update scripts

* Finish outbound messaging

* Implement token registration for V2

* Make functions payable

* improve docs

* Parachain relayer V2

* Rename to PendingOrder

* Decode compact int

* comments

* Improve doc

* review feedback

* cleanups

* Add initial tests for V2

* Make `rewardAddress` an indexed event parameter

* Remove unused

* Submit delivery proof

* Rename to InboundMessageV2

* Mark as view function

* Filter with reward address

* Clean up interfaces

* Make WETH address configurable

* Autowrap ether

* V2 smoke tests (#1327)

* 
8000
Update contracts for smoke tests

* Remove unused

* Decode test

* Update subxt

* Register PNA with OutbountQueueV2

* Fix storage key

* Comment out config

* Revert contract changes

* Fix function

* Regenerate binds & update package path

* Format

* Format

* Add todo

* Update bindings

* Update script

* auto-unwrap ether

* Update smoke tests

* Add view keyword

* More refactoring

* Verify V2 digest for commitment

* Call Contract with value

* improve

* improve

* allow unlocking native ether

* improve token registration flows

* improve docs

* improve

* improve

* nit

* Fix smoke test for V2

* Fix test

* Fix unlock WETH

* Sync with contract

* Fix smoke test

* Update contracts/src/v1/Calls.sol

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

* Apply suggestions from code review

Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>

* Fix unlock WETH

* Suppress Error (6243): The "tload" instruction

* Merge recent changes

* Fix breaking tests

* Fix tests

* Filter order by rewardAddress to handle own delivery proof

* Fix test

* Add ofac check

---------

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>

* Fix V2  tests (#1378)

* Fix smoke tests

* Add smoke tests

* Prefund transfer ENA

* Create agent (#1388)

* Create agent on Ethereum

* Add test

* Fix forge test

* Revamp smoke test

* Update go bindings

* Add register relay token back

* Fix transfer pna

* Remove obsolete code

* Update contracts/src/v2/Types.sol

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>

* Update foundry.toml

* Rename follow the naming scheme

* Fix smoke test

* Fix function name

---------

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>

* Fix test coverage reports (#1390)

* Gateway should no longer build token registration XCM (#1381)

* Rather build register token on BH

* Add comments

* adds metadata fields to register token

* Revert "adds metadata fields to register token"

This reverts commit 90cbff5.

* update tests

* Cleanup

* Update bindings

* remove kusama as supported network

---------

Co-authored-by: claravanstaden <claravanstaden64@gmail.com>
Co-authored-by: ron <yrong1997@gmail.com>

* Improve smoke tests (#1396)

* Rather build register token on BH

* Add comments

* adds metadata fields to register token

* Revert "adds metadata fields to register token"

This reverts commit 90cbff5.

* update tests

* Cleanup

* Update bindings

* Fix smoke test send token to destination chain

* Rename path

* Add send pna

* Check amount

---------

Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>
Co-authored-by: claravanstaden <claravanstaden64@gmail.com>

* cherry-pick token changes from main

* Revert "cherry-pick token changes from main"

This reverts commit 9731690.

* Improve ERC20 implementation (#1384)

* Add more docs

* Log topic on ethereum side (#1404)

* Log topic on ethereum side

* Fix test

* Update relayer

---------

Co-authored-by: ron <yrong1997@gmail.com>

* Delete obsolete code

* improve comments

* cleanups after static analysis

* Remove handlers for deprecated V1 commands

* format code

* format comments

* Refactor agent creation code

* Add test for foreign token registration

* Add tests for mint foreign token

* Improve docs

* Update bindings

* Merge from V1 (#1422)

* Add support for ether (#1409)

* Upgrade gateway on Sepolia for westend (#1407)

* Log gateway codehash

* Upgrade Gateway on Westend-Sepolia

* Update indexer endpoint & Cleanup (#1411)

* Ban lido token (#1412)

* Fix hardcoded url (#1414)

* Register Polkadot Native Assets in Control Tool (#1405)

* added function to register tokens

* fmt

* fix build errors

* clean up

* more assets

* fix message

* more tokens

* Update control/preimage/src/commands.rs

---------

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

* Force rebuild (#1418)

* Update with V1 bindings

* Remove channel config

* Remove channel

* Remove topic id from InboundMessageDispatched

* Format codes (#1416)

* Generate delivery receipt

* Revert "Remove topic id from InboundMessageDispatched"

This reverts commit 7e77f49.

	modified:   smoketest/src/helper.rs
	modified:   web/packages/test/scripts/build-binary.sh

* Fix script

* Clean up unused code

* Cleanup

* Minor fix

* Fix binding

* Change storage location

* Fix template

---------

Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

* Merge updates from V1 (#1429)

* Add support for ether (#1409)

* Upgrade gateway on Sepolia for westend (#1407)

* Log gateway codehash

* Upgrade Gateway on Westend-Sepolia

* Update indexer endpoint & Cleanup (#1411)

* Ban lido token (#1412)

* Fix hardcoded url (#1414)

* Register Polkadot Native Assets in Control Tool (#1405)

* added function to register tokens

* fmt

* fix build errors

* clean up

* more assets

* fix message

* more tokens

* Update control/preimage/src/commands.rs

---------

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

* Force rebuild (#1418)

* Format codes (#1416)

* remove equilibrium and its stable coin (#1421)

* Hot fix (#1424)

* Update Bifrost RPC endpoint

* Update package

* Update geth to v.15.5 in order to support decoding of SetCodeTx (#1426)

* update geth to v.15.5 in order to support decoding of SetCodeTx

* update go to 1.23.0

* update Go version in CI

* fix breaking test

* Cleanup

---------

Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>
Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: Parth <desaiparth08@gmail.com>

* For V1 compatibility (#1428)

* Merge recent changes from V1

* Fix smoke tests

* Update go.work.sum

* Improve smoke tests

---------

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
Co-authored-by: ron <yrong1997@gmail.com>
Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>
Co-authored-by: Parth <desaiparth08@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claravanstaden claravanstaden claravanstaden left review comments

@yrong yrong yrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ParthDesai @vgeddes @claravanstaden @yrong
0